Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more logging for ChannelPool shutdown #2070

Merged
merged 4 commits into from
Oct 6, 2023
Merged

feat: more logging for ChannelPool shutdown #2070

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72355ce
feat: more logging for ChannelPool shutdown
igorbernstein2 Oct 5, 2023
24fcf1c
format
igorbernstein2 Oct 5, 2023
15000f5
remove stacktrace to avoid trigger error reporting
igorbernstein2 Oct 6, 2023
c85aa54
format
igorbernstein2 Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/ChannelPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ Channel getChannel(int affinity) {
/** {@inheritDoc} */
@Override
public ManagedChannel shutdown() {
LOG.fine("Initiating graceful shutdown due to explicit request");

List<Entry> localEntries = entries.get();
for (Entry entry : localEntries) {
entry.channel.shutdown();
Expand Down Expand Up @@ -191,6 +193,8 @@ public boolean isTerminated() {
/** {@inheritDoc} */
@Override
public ManagedChannel shutdownNow() {
LOG.fine("Initiating immediate shutdown due to explicit request");

List<Entry> localEntries = entries.get();
for (Entry entry : localEntries) {
entry.channel.shutdownNow();
Expand Down Expand Up @@ -356,6 +360,7 @@ void refresh() {
// - then thread2 will shut down channel that thread1 will put back into circulation (after it
// replaces the list)
synchronized (entryWriteLock) {
LOG.fine("Refreshing all channels");
ArrayList<Entry> newEntries = new ArrayList<>(entries.get());

for (int i = 0; i < newEntries.size(); i++) {
Expand Down
Loading