fix: eliminate raw-types and remove unnecessary cast

[burkedavison]

No description provided.

[emmileaf]

LGTM - thank you for these fixes!

(Nit on PR naming: perhaps prefix with something like fix(spring) or fix(Spring CodeGen), just to help differentiate with PRs merging into the main branch?)

[blakeli0]

Can we change <? extends T> to T as well? Looks like what gets returned are always the same type?

[burkedavison]

T is valid for the current source; but as a Util function, the limit of the implementation is <? extends T> which defines how it can be used in the future as well. This also decouples future functions from needing to return the same type of AstNode list.

[burkedavison]

For example, without the ? extends T, it wouldn't be possible to combine type-related-but-not-the-same helper functions:

abstract List<CommentStatement> getHeaderComments(String methodName);
abstract List<Statement> getStatements(String methodName);
private static <T> List<T> NONE(String unused) { return Collections.emptyList(); }

private void example() {
  List<Statement> statements = Util.processRetrySettings(
    server,
    config,
    clazzType,
    this::getHeaderComments,
    this::getStatements,
    this::NONE
}

[blakeli0]

I agree with the general idea. But for this util method, it's a very specific use case(Create retry settings with some hardcoded method names) that is only used by the two composers, so I doubt it will be used by anything else. I could also argue that this method should not be a public Util, maybe it should be in something like a AbstractSpringComposer with default scope.
That being said, I don't think this is critical enough to block the PR, so either way works.

[zhumin8]

Thanks for fixing this!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication