From d3fca4602b86dd8bed02f515141e6cfbdde5cd44 Mon Sep 17 00:00:00 2001 From: "gcf-owl-bot[bot]" <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Date: Thu, 30 Jun 2022 02:24:27 +0000 Subject: [PATCH] docs: clarify descriptions of the AdvancedSettings and WebhookRequest data types (#501) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 458000126 Source-Link: https://github.com/googleapis/googleapis/commit/c425ac6db94418da95465842a747eefdca28d6fb Source-Link: https://github.com/googleapis/googleapis-gen/commit/1b0446dbaba086f1bf64d976b180d6ab6f338eb6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWIwNDQ2ZGJhYmEwODZmMWJmNjRkOTc2YjE4MGQ2YWI2ZjMzOGViNiJ9 --- .../dialogflow/cx/v3beta1/AdvancedSettings.java | 14 ++++++++++++-- .../dialogflow/cx/v3beta1/WebhookRequest.java | 4 ++++ .../dialogflow/cx/v3beta1/advanced_settings.proto | 8 +++++++- .../cloud/dialogflow/cx/v3beta1/webhook.proto | 3 +++ 4 files changed, 26 insertions(+), 3 deletions(-) diff --git a/proto-google-cloud-dialogflow-cx-v3beta1/src/main/java/com/google/cloud/dialogflow/cx/v3beta1/AdvancedSettings.java b/proto-google-cloud-dialogflow-cx-v3beta1/src/main/java/com/google/cloud/dialogflow/cx/v3beta1/AdvancedSettings.java index 200d0314c..9264af016 100644 --- a/proto-google-cloud-dialogflow-cx-v3beta1/src/main/java/com/google/cloud/dialogflow/cx/v3beta1/AdvancedSettings.java +++ b/proto-google-cloud-dialogflow-cx-v3beta1/src/main/java/com/google/cloud/dialogflow/cx/v3beta1/AdvancedSettings.java @@ -24,7 +24,12 @@ *
  * Hierarchical advanced settings for agent/flow/page/fulfillment/parameter.
  * Settings exposed at lower level overrides the settings exposed at higher
- * level.
+ * level. Overriding occurs at the sub-setting level. For example, the
+ * playback_interruption_settings at fulfillment level only overrides the
+ * playback_interruption_settings at the agent level, leaving other settings
+ * at the agent level unchanged.
+ * DTMF settings does not override each other. DTMF settings set at different
+ * levels define DTMF detections running in parallel.
  * Hierarchy: Agent->Flow->Page->Fulfillment/Parameter.
  * 
* @@ -1041,7 +1046,12 @@ protected Builder newBuilderForType(com.google.protobuf.GeneratedMessageV3.Build *
    * Hierarchical advanced settings for agent/flow/page/fulfillment/parameter.
    * Settings exposed at lower level overrides the settings exposed at higher
-   * level.
+   * level. Overriding occurs at the sub-setting level. For example, the
+   * playback_interruption_settings at fulfillment level only overrides the
+   * playback_interruption_settings at the agent level, leaving other settings
+   * at the agent level unchanged.
+   * DTMF settings does not override each other. DTMF settings set at different
+   * levels define DTMF detections running in parallel.
    * Hierarchy: Agent->Flow->Page->Fulfillment/Parameter.
    * 
* diff --git a/proto-google-cloud-dialogflow-cx-v3beta1/src/main/java/com/google/cloud/dialogflow/cx/v3beta1/WebhookRequest.java b/proto-google-cloud-dialogflow-cx-v3beta1/src/main/java/com/google/cloud/dialogflow/cx/v3beta1/WebhookRequest.java index db470fb33..aeca0a744 100644 --- a/proto-google-cloud-dialogflow-cx-v3beta1/src/main/java/com/google/cloud/dialogflow/cx/v3beta1/WebhookRequest.java +++ b/proto-google-cloud-dialogflow-cx-v3beta1/src/main/java/com/google/cloud/dialogflow/cx/v3beta1/WebhookRequest.java @@ -24,6 +24,8 @@ *
  * The request message for a webhook call. The request is sent as a JSON object
  * and the field names will be presented in camel cases.
+ * You may see undocumented fields in an actual request. These fields are used
+ * internally by Dialogflow and should be ignored.
  * 
* * Protobuf type {@code google.cloud.dialogflow.cx.v3beta1.WebhookRequest} @@ -5458,6 +5460,8 @@ protected Builder newBuilderForType(com.google.protobuf.GeneratedMessageV3.Build *
    * The request message for a webhook call. The request is sent as a JSON object
    * and the field names will be presented in camel cases.
+   * You may see undocumented fields in an actual request. These fields are used
+   * internally by Dialogflow and should be ignored.
    * 
* * Protobuf type {@code google.cloud.dialogflow.cx.v3beta1.WebhookRequest} diff --git a/proto-google-cloud-dialogflow-cx-v3beta1/src/main/proto/google/cloud/dialogflow/cx/v3beta1/advanced_settings.proto b/proto-google-cloud-dialogflow-cx-v3beta1/src/main/proto/google/cloud/dialogflow/cx/v3beta1/advanced_settings.proto index 92b2176ca..051f8259f 100644 --- a/proto-google-cloud-dialogflow-cx-v3beta1/src/main/proto/google/cloud/dialogflow/cx/v3beta1/advanced_settings.proto +++ b/proto-google-cloud-dialogflow-cx-v3beta1/src/main/proto/google/cloud/dialogflow/cx/v3beta1/advanced_settings.proto @@ -29,7 +29,13 @@ option ruby_package = "Google::Cloud::Dialogflow::CX::V3beta1"; // Hierarchical advanced settings for agent/flow/page/fulfillment/parameter. // Settings exposed at lower level overrides the settings exposed at higher -// level. +// level. Overriding occurs at the sub-setting level. For example, the +// playback_interruption_settings at fulfillment level only overrides the +// playback_interruption_settings at the agent level, leaving other settings +// at the agent level unchanged. +// +// DTMF settings does not override each other. DTMF settings set at different +// levels define DTMF detections running in parallel. // // Hierarchy: Agent->Flow->Page->Fulfillment/Parameter. message AdvancedSettings { diff --git a/proto-google-cloud-dialogflow-cx-v3beta1/src/main/proto/google/cloud/dialogflow/cx/v3beta1/webhook.proto b/proto-google-cloud-dialogflow-cx-v3beta1/src/main/proto/google/cloud/dialogflow/cx/v3beta1/webhook.proto index ca3c850c2..3cddccda5 100644 --- a/proto-google-cloud-dialogflow-cx-v3beta1/src/main/proto/google/cloud/dialogflow/cx/v3beta1/webhook.proto +++ b/proto-google-cloud-dialogflow-cx-v3beta1/src/main/proto/google/cloud/dialogflow/cx/v3beta1/webhook.proto @@ -273,6 +273,9 @@ message DeleteWebhookRequest { // The request message for a webhook call. The request is sent as a JSON object // and the field names will be presented in camel cases. +// +// You may see undocumented fields in an actual request. These fields are used +// internally by Dialogflow and should be ignored. message WebhookRequest { // Represents fulfillment information communicated to the webhook. message FulfillmentInfo {