From 1378107d019759c2fc48bc41262d928dbb43a7f1 Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Sat, 23 Mar 2024 15:03:47 +0000 Subject: [PATCH 1/3] feat: Add google.api.api_version annotation to echo.proto --- schema/google/showcase/v1beta1/echo.proto | 2 ++ 1 file changed, 2 insertions(+) diff --git a/schema/google/showcase/v1beta1/echo.proto b/schema/google/showcase/v1beta1/echo.proto index 268fbe4dc..7803f4426 100644 --- a/schema/google/showcase/v1beta1/echo.proto +++ b/schema/google/showcase/v1beta1/echo.proto @@ -43,6 +43,8 @@ service Echo { // This service is meant to only run locally on the port 7469 (keypad digits // for "show"). option (google.api.default_host) = "localhost:7469"; + // See https://github.com/aip-dev/google.aip.dev/pull/1331 + option (google.api.api_version) = "v1_20240325"; // This method simply echoes the request. This method showcases unary RPCs. rpc Echo(EchoRequest) returns (EchoResponse) { From 81c1a8c7381f5219b4996dd86ce346966444ee0a Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Sat, 23 Mar 2024 15:17:53 +0000 Subject: [PATCH 2/3] update the api_version to a nonsense value to refelect that it should be opaque to clients as per AIP --- schema/google/showcase/v1beta1/echo.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schema/google/showcase/v1beta1/echo.proto b/schema/google/showcase/v1beta1/echo.proto index 7803f4426..7b0d5d104 100644 --- a/schema/google/showcase/v1beta1/echo.proto +++ b/schema/google/showcase/v1beta1/echo.proto @@ -44,7 +44,7 @@ service Echo { // for "show"). option (google.api.default_host) = "localhost:7469"; // See https://github.com/aip-dev/google.aip.dev/pull/1331 - option (google.api.api_version) = "v1_20240325"; + option (google.api.api_version) = "moose"; // This method simply echoes the request. This method showcases unary RPCs. rpc Echo(EchoRequest) returns (EchoResponse) { From a37732121833e0a9d589611bb2b60b32b85d1479 Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Mon, 8 Apr 2024 20:22:54 -0400 Subject: [PATCH 3/3] Address review feedback --- schema/google/showcase/v1beta1/echo.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schema/google/showcase/v1beta1/echo.proto b/schema/google/showcase/v1beta1/echo.proto index 7b0d5d104..eda1861a2 100644 --- a/schema/google/showcase/v1beta1/echo.proto +++ b/schema/google/showcase/v1beta1/echo.proto @@ -44,7 +44,7 @@ service Echo { // for "show"). option (google.api.default_host) = "localhost:7469"; // See https://github.com/aip-dev/google.aip.dev/pull/1331 - option (google.api.api_version) = "moose"; + option (google.api.api_version) = "v1_20240408"; // This method simply echoes the request. This method showcases unary RPCs. rpc Echo(EchoRequest) returns (EchoResponse) {