Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stream method for ServerStream #1575

Merged
merged 10 commits into from
Apr 11, 2023
Merged

feat: add stream method for ServerStream #1575

merged 10 commits into from
Apr 11, 2023

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Mar 28, 2023 •
edited
Loading

Fixes #1576 ☕️

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 28, 2023
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2023
@JoeWang1127 JoeWang1127 marked this pull request as ready for review March 30, 2023 19:52
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner March 30, 2023 19:52
@burkedavison
Copy link
Contributor

LGTM

suztomo
suztomo approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this at the same time as the Page's

@suztomo suztomo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 31, 2023
blakeli0
blakeli0 reviewed Mar 31, 2023
View reviewed changes
gax-java/gax/src/main/java/com/google/api/gax/rpc/ServerStream.java
@@ -89,6 +91,10 @@ public Iterator<V> iterator() {
return iterator;
}

public Stream<V> stream() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add Javadoc? All public methods are required to have Javadoc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

blakeli0
blakeli0 reviewed Mar 31, 2023
View reviewed changes
gax-java/gax/src/main/java/com/google/api/gax/rpc/ServerStream.java
@@ -89,6 +91,10 @@ public Iterator<V> iterator() {
return iterator;
}

public Stream<V> stream() {
return StreamSupport.stream(this.spliterator(), false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the second argument is set to false, which means this is a sequential stream, do we want to expose another parallelStream method as well?

Copy link
Collaborator Author

@JoeWang1127 JoeWang1127 Mar 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether a deterministic result is required as parallel stream can randomize the result.

Also, we could explore more about parallel stream later as we did in Page.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 1, 2023
@suztomo suztomo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JoeWang1127 JoeWang1127 merged commit e38c8ec into main Apr 11, 2023
@JoeWang1127 JoeWang1127 deleted the feat/add-stream-in-ServerStream branch April 11, 2023 17:49
@release-please release-please bot mentioned this pull request Apr 11, 2023
Merged
JoeWang1127 pushed a commit that referenced this pull request Apr 11, 2023
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
014bafc 
…1575) (#914)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
JoeWang1127 pushed a commit that referenced this pull request Apr 11, 2023
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
ef3cdc5 
…1575) (#795)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@blakeli0 blakeli0 blakeli0 approved these changes

@burkedavison burkedavison Awaiting requested review from burkedavison

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ServerStream do not easily support Java Streams
4 participants
@JoeWang1127 @burkedavison @suztomo @blakeli0