Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): do not emit empty rm commands #1027

Merged
merged 1 commit into from
Aug 19, 2022
Merged

fix(bazel): do not emit empty rm commands #1027

merged 1 commit into from
Aug 19, 2022

Conversation

alexander-fenster
Copy link
Contributor

The googleapis Bazel build logs have a lot of

INFO: From Action google/cloud/aiplatform/v1beta1/proto-google-cloud-aiplatform-v1beta1-java-srcs_pkg.tar.gz:
rm: missing operand
Try 'rm --help' for more information.
rm: missing operand
Try 'rm --help' for more information.
rm: missing operand
Try 'rm --help' for more information.
rm: missing operand
Try 'rm --help' for more information.
rm: missing operand
Try 'rm --help' for more information.
rm: missing operand
Try 'rm --help' for more information.

I'm assuming it can only come from the line I'm changing here, in case if there are no files with zero size. I'm changing it so that it will only called rm if needed.

@alexander-fenster alexander-fenster requested review from a team as code owners August 19, 2022 04:45
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

blakeli0
blakeli0 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! LGTM

@alexander-fenster alexander-fenster merged commit 7064f4c into main Aug 19, 2022
@alexander-fenster alexander-fenster deleted the no-empty-rm branch August 19, 2022 17:39
@release-please release-please bot mentioned this pull request Aug 19, 2022
Merged
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@alexander-fenster
fix(bazel): do not emit empty rm commands (#1027)
47ac952
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@gcf-owl-bot
chore: use gcp-docuploader 0.6.3 (#1708) (#1027)
468f7a9 
Source-Link: googleapis/synthtool@fbc8bfe
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e76136cc48f90aa19ba29cdfbd4002111467e44a1c9d905867d98dafafbd03bb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-fenster @blakeli0