Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully automate doc publication #1463

Open
proppy opened this issue Jun 6, 2024 · 4 comments
Open

fully automate doc publication #1463

proppy opened this issue Jun 6, 2024 · 4 comments
Labels
build Related to build flow, build system, or build macros documentation Improvements or additions to documentation enhancement New feature or request

Comments

@proppy
Copy link
Member

proppy commented Jun 6, 2024

It seems that the current documentation process is not fully automated:

@cdleary, @meheff any background on why things were setup that way?

We should consider streamlining the process w/ the following changes:

@proppy proppy added documentation Improvements or additions to documentation enhancement New feature or request build Related to build flow, build system, or build macros labels Jun 6, 2024
@cdleary
Copy link
Collaborator

cdleary commented Jun 6, 2024

I think the basic constraints/thinking that led to this kind of setup was:

  • We kind of wanted the rendered docs to be available in-tree (though this isn't a hard requirement, would be reasonable to not have them in tree I think, just a preference at the time thing)
  • No easy way to do it on the piper side before syncing out
  • Didn't really want an automated rendering commit after every source change commit because it gunks up the commit history
  • Nice to have it hosted naturally at the "github pages sister URL of the repo" google.github.io/xls/

Plus probably just "what seemed easy to do" / "automating what we were doing by hand". Other approaches are reasonable.

@cdleary
Copy link
Collaborator

cdleary commented Jun 6, 2024

Note that this is also why we remap the g3doc folder to docs_src and render to docs/ (because that's where pages wants to look).

@proppy
Copy link
Member Author

proppy commented Jun 6, 2024

Didn't really want an automated rendering commit after every source change commit because it gunks up the commit history

I can definitly empathize w/ that!

The nice thing, now that github has https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow, is that we can publish directly from the workflow artefacts w/o commiting anything to main or gh-pages branches.

@cdleary
Copy link
Collaborator

cdleary commented Jun 6, 2024

Cool, so long as there's a hosted site with docs I think it's all good options :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to build flow, build system, or build macros documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants