{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":262163993,"defaultBranch":"main","name":"xls","ownerLogin":"google","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-05-07T21:38:30.000Z","ownerAvatar":"https://github.com/avatars/u/1342004?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1727423692.0","currentOid":""},"activityList":{"items":[{"before":"c8a5247d8fcde1a6ba006c60c20a7734a3ab716e","after":"67b00336b25b71a43313b79fd7905010e5754e9e","ref":"refs/heads/main","pushedAt":"2024-09-28T01:02:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Add support for collecting node-value coverage information to eval_ir/proc_main\n\nPiperOrigin-RevId: 679791162","shortMessageHtmlLink":"Add support for collecting node-value coverage information to eval_ir…"}},{"before":"6fa1d6feab3a8d488ab872498c198e4e0fcb5a8e","after":"c8a5247d8fcde1a6ba006c60c20a7734a3ab716e","ref":"refs/heads/main","pushedAt":"2024-09-28T00:20:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Add support for observing the value of every node with the jit.\n\nThis adds node-value support to the jit. To recieve node value events support must be specifically requested when creating the jit as the callback has a performance penalty for existing at all, even if the callback is not used for anything.\n\nPiperOrigin-RevId: 679781241","shortMessageHtmlLink":"Add support for observing the value of every node with the jit."}},{"before":"0525b3850268a552db79d6d2eb1249af77b62f64","after":"6fa1d6feab3a8d488ab872498c198e4e0fcb5a8e","ref":"refs/heads/main","pushedAt":"2024-09-27T23:46:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Add support for observing the value of every node.\n\nIt can be useful to observe the value every node takes when evaluating a IR program in order to generate coverage reports. This adds support to the XLS interpreter to collect this kind of data.\n\nPiperOrigin-RevId: 679772066","shortMessageHtmlLink":"Add support for observing the value of every node."}},{"before":"30bf746afe69644de6abeed0631ee5915704ec41","after":"0525b3850268a552db79d6d2eb1249af77b62f64","ref":"refs/heads/main","pushedAt":"2024-09-27T23:10:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Fix block IR -> verilog for instantiations with array types.\n\nInternal to a module, we use unpacked array types (ref: google/xls#320), but at port boundaries we flatten. This was not correctly accounted for in how we handled block instantiations. This change flattens unpacked arrays at instantiation boundaries.\n\nPiperOrigin-RevId: 679761183","shortMessageHtmlLink":"Fix block IR -&gt; verilog for instantiations with array types."}},{"before":"1af3c8cf8144f46be9bca6e44b98477adfe5dd8d","after":"30bf746afe69644de6abeed0631ee5915704ec41","ref":"refs/heads/main","pushedAt":"2024-09-27T22:09:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Allow channel metadata to be referenced from multiple blocks.\n\nIn multi-proc codegen, the two sides of a channel have ports in potentially different blocks, but the metadata only reflected one of them (based on execution order). This change makes it so that channel metadata can reference the port names for any block it exists in. As is usual with signatures, this has a significant blast radius.\n\nProgress towards google/xls#1323.\n\nPiperOrigin-RevId: 679743038","shortMessageHtmlLink":"Allow channel metadata to be referenced from multiple blocks."}},{"before":"bb041f30adbe1e87b78770e72fa5a53cfd3d1f60","after":"1af3c8cf8144f46be9bca6e44b98477adfe5dd8d","ref":"refs/heads/main","pushedAt":"2024-09-27T21:05:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Add unimplemented `impl` to the ast.\n\nhttps://github.com/google/xls/issues/1277\n\nPiperOrigin-RevId: 679721290","shortMessageHtmlLink":"Add unimplemented <code>impl</code> to the ast."}},{"before":"3d7cdf620bf94ee1594e0a41f450ea033a16c558","after":"bb041f30adbe1e87b78770e72fa5a53cfd3d1f60","ref":"refs/heads/main","pushedAt":"2024-09-27T20:41:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"RET_CHECK that extern types aren't used with arrays.\n\nOur current handling of arrays packs them into a single bitvector at port boundaries and adds assignments to internal unpacked arrays. Using true array types from an extern type violates this expectation and the indexing may not work.\n\nSee google/xls#1637.\n\nPiperOrigin-RevId: 679713175","shortMessageHtmlLink":"RET_CHECK that extern types aren't used with arrays."}},{"before":"6936c719dc68bd9296543627b2d59ef328b05dd9","after":"3d7cdf620bf94ee1594e0a41f450ea033a16c558","ref":"refs/heads/main","pushedAt":"2024-09-27T18:02:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Add fuzzing example 2024-09-26_ac56\n\nIssues: https://github.com/google/xls/issues/1636\nPiperOrigin-RevId: 679654208","shortMessageHtmlLink":"Add fuzzing example 2024-09-26_ac56"}},{"before":"5eed6363a440c4591f0ff3754ff173f8205b672d","after":"6936c719dc68bd9296543627b2d59ef328b05dd9","ref":"refs/heads/main","pushedAt":"2024-09-27T17:33:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Don't use potentially ambiguous IrInterpreter constructor.\n\nUsing an empty initializer-list can be ambiguous if more options are added to IrInterpreter (especially since the current resolution as a flat_hash_map* is somewhat surprising). Don't use any arguments if all that's required is an empty interpreter.\n\nPiperOrigin-RevId: 679642102","shortMessageHtmlLink":"Don't use potentially ambiguous IrInterpreter constructor."}},{"before":"d7fa54927bd7152f86cb6a5f7590d38fa636225a","after":"5eed6363a440c4591f0ff3754ff173f8205b672d","ref":"refs/heads/main","pushedAt":"2024-09-26T23:20:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Make FifoConfig constexpr-constructible.\n\nPiperOrigin-RevId: 679331734","shortMessageHtmlLink":"Make FifoConfig constexpr-constructible."}},{"before":"3713bfed14390b4dedc2e6110b36a6f4e3f57a8e","after":"d7fa54927bd7152f86cb6a5f7590d38fa636225a","ref":"refs/heads/main","pushedAt":"2024-09-26T21:43:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Clean up some documentation in codegen.\n\nPiperOrigin-RevId: 679300186","shortMessageHtmlLink":"Clean up some documentation in codegen."}},{"before":"2f7ea3eed00a4c794cf8ffb7676bf615b1e83082","after":"3713bfed14390b4dedc2e6110b36a6f4e3f57a8e","ref":"refs/heads/main","pushedAt":"2024-09-26T21:35:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Add default fifo config option to IR conversion.\n\nImplement the default fifo config option in IR converter.\n\nFixes google/xls#1630.\n\nPiperOrigin-RevId: 679297321","shortMessageHtmlLink":"Add default fifo config option to IR conversion."}},{"before":"5a58ad614605f66a17a994b71ea4a96e00ae9fe5","after":"2f7ea3eed00a4c794cf8ffb7676bf615b1e83082","ref":"refs/heads/main","pushedAt":"2024-09-26T21:33:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Encapsulate ir converter options in a proto.\n\nThis makes ir conversion options similar to how scheduling and codegen options are handled.\n\nPiperOrigin-RevId: 679296109","shortMessageHtmlLink":"Encapsulate ir converter options in a proto."}},{"before":"de08f3b6745a8eb38080045ae2f4289536ac6e58","after":"5a58ad614605f66a17a994b71ea4a96e00ae9fe5","ref":"refs/heads/main","pushedAt":"2024-09-26T18:33:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"[xlscc] Use visitor for short circuit logic.\n\nThis seems to be more efficient than the hand-rolled DFS from before.\n\nPiperOrigin-RevId: 679228922","shortMessageHtmlLink":"[xlscc] Use visitor for short circuit logic."}},{"before":"7c3c7cd068200df52721c4ba337985ad3fcb7cd9","after":"de08f3b6745a8eb38080045ae2f4289536ac6e58","ref":"refs/heads/main","pushedAt":"2024-09-26T17:44:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Back `ConditionSet` with an inlined-vector instead of a btree.\n\nSince we're never storing more than `kMaxConditions` (64) conditions, this is more efficient by avoiding allocating, even when we need to keep the set sorted manually.\n\nPiperOrigin-RevId: 679207846","shortMessageHtmlLink":"Back <code>ConditionSet</code> with an inlined-vector instead of a btree."}},{"before":"78e9a0df9139da174b25c567bd5880907c37372a","after":"7c3c7cd068200df52721c4ba337985ad3fcb7cd9","ref":"refs/heads/main","pushedAt":"2024-09-26T17:30:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Add a new overload of LTT::CreateFromFunction that omits the index\n\nIf we don't have to build the index, we can actually implement this much more efficiently, iterating over the flat array of leaf types rather than traversing the root type as we go.\n\nPiperOrigin-RevId: 679202111","shortMessageHtmlLink":"Add a new overload of LTT::CreateFromFunction that omits the index"}},{"before":"a29cae6f3c822c628f20cc19d36b9132bba643ce","after":"78e9a0df9139da174b25c567bd5880907c37372a","ref":"refs/heads/main","pushedAt":"2024-09-26T16:34:15.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Merge pull request #1622 from xlsynth:cdleary/2024-09-22-c-api-dslx-defs\n\nPiperOrigin-RevId: 679181571","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2541565158\" data-permission-text=\"Title is private\" data-url=\"https://github.com/google/xls/issues/1622\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/google/xls/pull/1622/hovercard\" href=\"https://github.com/google/xls/pull/1622\">#1622</a> from xlsynth:cdleary/2024-09-22-c-api-dslx-defs"}},{"before":"d7f47386e80839a5824c8828317f0729330b400d","after":"a29cae6f3c822c628f20cc19d36b9132bba643ce","ref":"refs/heads/main","pushedAt":"2024-09-26T00:16:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Make the default dslx stdlib path an `inline constexpr std::string_view`.\n\nPiperOrigin-RevId: 678905008","shortMessageHtmlLink":"Make the default dslx stdlib path an `inline constexpr std::string_vi…"}},{"before":"aeb1353f83c30def2d9d4734ccf862220068c157","after":"d7f47386e80839a5824c8828317f0729330b400d","ref":"refs/heads/main","pushedAt":"2024-09-25T22:28:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Add trace channel functionality to IR JIT/interpreter.\nAdd ability to record traces when values are written to / read from channels. This is analagous to the --trace_channels functionality in the DSLX interpreter.\n\nPiperOrigin-RevId: 678869389","shortMessageHtmlLink":"Add trace channel functionality to IR JIT/interpreter."}},{"before":"539090f8e16e84fe8290c8a60f6eed7979bd4e59","after":"aeb1353f83c30def2d9d4734ccf862220068c157","ref":"refs/heads/main","pushedAt":"2024-09-25T22:19:26.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Merge pull request #1629 from hzeller:feature-20240925-fix-public-incs\n\nPiperOrigin-RevId: 678866572","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2548937242\" data-permission-text=\"Title is private\" data-url=\"https://github.com/google/xls/issues/1629\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/google/xls/pull/1629/hovercard\" href=\"https://github.com/google/xls/pull/1629\">#1629</a> from hzeller:feature-20240925-fix-public-incs"}},{"before":"3a37c289f7fc175fd6d0592afb5c8ece5f5b77eb","after":"539090f8e16e84fe8290c8a60f6eed7979bd4e59","ref":"refs/heads/main","pushedAt":"2024-09-25T21:38:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Open source initial version of XLS dialect.\n\nThis is WIP dialect meant for interop with XLS. It is still under active\ndevelopment and considered experimental/may change at any given time. This\ninitial version is build on interface exposed by FunctionBuilder along with\nsome convenience ops (e.g., structured procs).\n\nPiperOrigin-RevId: 678852375","shortMessageHtmlLink":"Open source initial version of XLS dialect."}},{"before":"816a3617d3d91f1e7f2c51cfc3d69dfc594216b8","after":"3a37c289f7fc175fd6d0592afb5c8ece5f5b77eb","ref":"refs/heads/main","pushedAt":"2024-09-25T17:16:19.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Merge pull request #1621 from xlsynth:cdleary/2024-09-22-c-api-multi-target\n\nPiperOrigin-RevId: 678749027","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2541181296\" data-permission-text=\"Title is private\" data-url=\"https://github.com/google/xls/issues/1621\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/google/xls/pull/1621/hovercard\" href=\"https://github.com/google/xls/pull/1621\">#1621</a> from xlsynth:cdleary/2024-09-22-c-api-multi-…"}},{"before":"a870be13783ed6a03b4d7c1400bd8d734b5eb6b8","after":"816a3617d3d91f1e7f2c51cfc3d69dfc594216b8","ref":"refs/heads/main","pushedAt":"2024-09-25T17:08:18.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Merge pull request #1620 from xlsynth:cdleary/2024-09-21-dslx-fmt-nest\n\nPiperOrigin-RevId: 678745896","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2540596267\" data-permission-text=\"Title is private\" data-url=\"https://github.com/google/xls/issues/1620\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/google/xls/pull/1620/hovercard\" href=\"https://github.com/google/xls/pull/1620\">#1620</a> from xlsynth:cdleary/2024-09-21-dslx-fmt-nest"}},{"before":"e5bcb56fbec2e09696fe2ea87a5d39ab347b49a8","after":"a870be13783ed6a03b4d7c1400bd8d734b5eb6b8","ref":"refs/heads/main","pushedAt":"2024-09-25T14:35:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Support instantiation of constant arrays of imported parametric `struct`s.\n\nLocally defined names and colon references are treated differently in the parser so we need to\nmanually parse the colon and array after a `ColonRef`.\n\nhttps://github.com/google/xls/issues/1030\n\nFixes #1030\n\nPiperOrigin-RevId: 678694390","shortMessageHtmlLink":"Support instantiation of constant arrays of imported parametric `stru…"}},{"before":"b3a7203c0a3bb8537577ee5403389b722894a311","after":"e5bcb56fbec2e09696fe2ea87a5d39ab347b49a8","ref":"refs/heads/main","pushedAt":"2024-09-24T22:56:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Tell clang-tidy explicitly to consider code c++20.\n\nEven though the -std=c++20 makes it into the\ncompilation DB, clang-tidy does not pick it up.\n\nSo be explicit and add it to the --extra-args on\ninvocation.\n\nThie fixes all reported [clang-diagnostic-error] that\nwere due to clang-tidy not recognizing c++20 constructs\nand also some misc-include-cleaner warnings in which it\npreviously flagged some includes because it was tripping\nover some other problem in the file in question.\n\n<    21 [misc-include-cleaner]\n<    20 [clang-diagnostic-error]\n---\n>    15 [misc-include-cleaner]\n\nPiperOrigin-RevId: 678427605","shortMessageHtmlLink":"Tell clang-tidy explicitly to consider code c++20."}},{"before":"3ca5faad624ad55688b4957e2ddd3f7cdac2b753","after":"b3a7203c0a3bb8537577ee5403389b722894a311","ref":"refs/heads/main","pushedAt":"2024-09-24T22:49:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Don't consider empty intervals precise.\n\nDuring analysis if a contradiction is found then intervals can end up 'empty' with no valid elements. Previously we returned 'true' for IsPrecise on these intervals which is incorrect.\n\nPiperOrigin-RevId: 678425439","shortMessageHtmlLink":"Don't consider empty intervals precise."}},{"before":"145799a38f087ef3f16f6e9b41da914c25677700","after":"3ca5faad624ad55688b4957e2ddd3f7cdac2b753","ref":"refs/heads/main","pushedAt":"2024-09-24T21:50:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Speed up `IntervalSet::Complement`.\n\nThe previous implementation modeled `Complement` as the intersection of the complements of the comprising intervals. However, since we already invoke `Intervals()` in this function, it only applies when the `IntervalSet` is already normalized... at which point, we can be more efficient by scanning linearly through the sorted list of non-abutting intervals & recording the unused values.\n\nPiperOrigin-RevId: 678405288","shortMessageHtmlLink":"Speed up <code>IntervalSet::Complement</code>."}},{"before":"c2d180153e4770891b9fdf068a0055a4b8ee68a5","after":"145799a38f087ef3f16f6e9b41da914c25677700","ref":"refs/heads/main","pushedAt":"2024-09-24T21:11:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"[xlscc] Reuse z3 IR translators.\n\nReusing z3 IR translators allows previous conversions to be reused, which provides significant savings as this translation is expensive.\n\nPiperOrigin-RevId: 678390950","shortMessageHtmlLink":"[xlscc] Reuse z3 IR translators."}},{"before":"929d7b011a89597a48d6addd114bce6fa219ee30","after":"c2d180153e4770891b9fdf068a0055a4b8ee68a5","ref":"refs/heads/main","pushedAt":"2024-09-24T20:51:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Fix bugs with type checking unroll_for! expressions.\n\nThe root cause of the specific case flagged in #1614 is that we were not uniformly applying the type-checking rules that should apply to all for loops. This change factors out the common type checking logic and applies it to both, then DeduceUnrollFor applies extra constraints.\n\nThis change also improves some existing error messages to stop talking about the (index, acc) tuple as a unit.\n\nhttps://github.com/google/xls/issues/1614\n\nFixes #1614\n\nPiperOrigin-RevId: 678383527","shortMessageHtmlLink":"Fix bugs with type checking unroll_for! expressions."}},{"before":"763f00f98e96ab783ba347c9c92eddf6fe4ea232","after":"929d7b011a89597a48d6addd114bce6fa219ee30","ref":"refs/heads/main","pushedAt":"2024-09-24T18:18:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://github.com/avatars/in/44061?s=80&v=4"},"commit":{"message":"Re-organize some misplaced code.\n\nPiperOrigin-RevId: 678324728","shortMessageHtmlLink":"Re-organize some misplaced code."}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yOFQwMTowMjoyNC4wMDAwMDBazwAAAATDIFZm","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yNFQxODoxODo1MC4wMDAwMDBazwAAAAS_fcU1"}},"title":"Activity · google/xls"}