Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make connection's getOffsetInBlock public #7227

Closed
1 task done
BeksOmega opened this issue Jun 29, 2023 · 1 comment · Fixed by #7258
Closed
1 task done

Make connection's getOffsetInBlock public #7227

BeksOmega opened this issue Jun 29, 2023 · 1 comment · Fixed by #7258
Assignees
Labels
good first issue issue: feature request Describes a new feature and why it should be added

Comments

@BeksOmega
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

The getOffsetInBlock method is @internal, which means that external developers aren't supposed to access it.

However, it is currently used by the debug renderer in @blockly/dev-tools as well as the marker_svgs in the default renderer and zelos.

Request

The getOffsetInBlock method should be made public. The fact that it is accessed by the marker_svgs is a particularly compelling reason, because we want external developers to be able to create their own marker_svgs, and this is a significant blocker to them doing so.

Alternatives considered

N/A

Additional context

google/blockly-samples#1747

@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Jun 29, 2023
@maribethb maribethb added good first issue and removed issue: triage Issues awaiting triage by a Blockly team member labels Jul 5, 2023
@maribethb
Copy link
Contributor

All that needs to happen here is remove the @internal annotation from getOffsetInBlock method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue issue: feature request Describes a new feature and why it should be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants