Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom blocks were removed from sample-app #2366

Closed
1 task
maribethb opened this issue May 20, 2024 · 2 comments · Fixed by #2374
Closed
1 task

custom blocks were removed from sample-app #2366

maribethb opened this issue May 20, 2024 · 2 comments · Fixed by #2374
Assignees
Labels
type: bug Something isn't working

Comments

@maribethb
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

sample-app
sample-ts-app

Description

In #2302 the custom blocks were removed from the toolboxes of the sample apps because they referenced the colour fields. However, demonstrating how to create custom blocks and add them to the toolbox is an essential part of the sample app. The apps should be updated to use the custom blocks, and the blocks just shouldn't use the colour field anymore.

Reproduction steps

Stack trace

No response

Screenshots

No response

@maribethb maribethb added type: bug Something isn't working triage labels May 20, 2024
@BeksOmega
Copy link
Contributor

Would it actually be helpful to have them use the colour field in samples? Then we can show the sample app using a plugin (assuming it doesn't do that already)

@maribethb
Copy link
Contributor Author

Yes, it would, but it's kind of a pain to keep examples updated as plugins are updated, and the stakes are higher if we break the sample app as opposed to breaking the react sample, so I'm conflicted on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants