-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caller inputs disconnect on reload if caller serialized above definition #1893
Comments
@BeksOmega since this is related to procedures, can you take a look and decide if it's fixable this quarter? |
I think this is probably actually #1049. The advanced playground uses XML on reload, which doesn't include the procedure models. @laurensvalk if you try this with JSON serialization, does it still reproduce? You can create a button in your test page that serializes to and loads back in JSON. [Edit: or just test it in the browser console] |
Thanks @BeksOmega. This appears to happen with JSON serialization too. I first noticed this in my own application, which does something like #1049 already because I use some features that are not supported by the XML loader. |
Category
Component
block-shareable-procedures
3.0.5
with Blockly10.1.3
.I think this did not occur with Blockly 10, but I have only verified
Describe the bug
Loading a project will disconnect and bump caller inputs if it is serialized above the definition.
I think this might only affect the JSON case where the order is based on appending instead of workspace placement.
To Reproduce
The easiest way is to add
block-shareable-procedures
to the playground.Steps:
Activate plugin in playground:
See video below for the reproduction steps:
Expected behavior
Not disconnect inputs.
Screenshots
update-2023-09-05_12.25.48.mp4
The text was updated successfully, but these errors were encountered: