fix: Test for minimap playground #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarades
requested review from
BeksOmega
and removed request for
a team and
BeksOmega
BeksOmega
approved these changes
Aug 23, 2023
|
Double checked that everything in the package config looks good =) Such excite! |
gonfunko
pushed a commit
to gonfunko/blockly-samples
that referenced
this pull request
Aug 25, 2023
* fixed test * removed private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you used the playground to change the workspace, it would create duplicate minimaps. To fix this I assigned the minimap to a module-local variable, and dispose of it if it already exists.
In this PR I also removed the private label from the package file.
Tests
To test that no minimaps were being duplicated I repeatedly altered the workspace attributes, and changed the window size.