Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gosec: disable G407 #4983

Merged
merged 2 commits into from
Sep 4, 2024
Merged

gosec: disable G407 #4983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
110f08a
gosec: disable G407
ldez Sep 4, 2024
f4f935e
chore: remove doc
ldez Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .golangci.next.reference.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,6 @@ linters-settings:
- G404 # Insecure random number source (rand)
- G405 # Detect the usage of DES or RC4
- G406 # Detect the usage of MD4 or RIPEMD160
- G407 # Detect the usage of hardcoded Initialization Vector(IV)/Nonce
- G501 # Import blocklist: crypto/md5
- G502 # Import blocklist: crypto/des
- G503 # Import blocklist: crypto/rc4
Expand Down Expand Up @@ -922,7 +921,6 @@ linters-settings:
- G404 # Insecure random number source (rand)
- G405 # Detect the usage of DES or RC4
- G406 # Detect the usage of MD4 or RIPEMD160
- G407 # Detect the usage of hardcoded Initialization Vector(IV)/Nonce
- G501 # Import blocklist: crypto/md5
- G502 # Import blocklist: crypto/des
- G503 # Import blocklist: crypto/rc4
Expand Down
1 change: 0 additions & 1 deletion jsonschema/golangci.next.jsonschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@
"G404",
"G405",
"G406",
"G407",
"G501",
"G502",
"G503",
Expand Down
5 changes: 5 additions & 0 deletions pkg/golinters/gosec/gosec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ func New(settings *config.GoSecSettings) *goanalysis.Linter {
var ruleFilters []rules.RuleFilter
var analyzerFilters []analyzers.AnalyzerFilter
if settings != nil {
// TODO(ldez) to remove when the problem will be fixed by gosec.
// https://github.com/securego/gosec/issues/1211
// https://github.com/securego/gosec/issues/1209
settings.Excludes = append(settings.Excludes, "G407")

ruleFilters = createRuleFilters(settings.Includes, settings.Excludes)
analyzerFilters = createAnalyzerFilters(settings.Includes, settings.Excludes)
conf = toGosecConfig(settings)
Expand Down
Loading