From 3e424a577f31e85f7a95c18c87066fee88139baa Mon Sep 17 00:00:00 2001
From: Dmitri Shuralyov <dmitshur@golang.org>
Date: Wed, 4 Oct 2023 18:31:43 -0400
Subject: [PATCH] shiny/driver/gldriver: stop activating regardless of the
 current app

Documentation for NSApplicationActivateIgnoringOtherApps warns:

> Important: You should rarely pass this flag because stealing
> key focus produces a poor user experience.

The flag is also deprecated and no longer has effect in macOS 14.
Stop setting it.

Change-Id: I8b8794332b54445866e038d9537a4b0eb4e75149
Cq-Include-Trybots: luci.golang.try:x_exp-gotip-darwin-amd64_14
Reviewed-on: https://go-review.googlesource.com/c/exp/+/532581
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
---
 shiny/driver/gldriver/cocoa.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/shiny/driver/gldriver/cocoa.m b/shiny/driver/gldriver/cocoa.m
index 2c8fd8376..1ae33973c 100644
--- a/shiny/driver/gldriver/cocoa.m
+++ b/shiny/driver/gldriver/cocoa.m
@@ -233,7 +233,7 @@ @interface AppDelegate : NSObject<NSApplicationDelegate>
 @implementation AppDelegate
 - (void)applicationDidFinishLaunching:(NSNotification *)aNotification {
 	driverStarted();
-	[[NSRunningApplication currentApplication] activateWithOptions:(NSApplicationActivateAllWindows | NSApplicationActivateIgnoringOtherApps)];
+	[[NSRunningApplication currentApplication] activateWithOptions:NSApplicationActivateAllWindows];
 }
 
 - (void)applicationWillTerminate:(NSNotification *)aNotification {