Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-2183: Increase the Clique MIN_WAIT for out-of-turn blocks #2183

Closed
wants to merge 4 commits into from

Conversation

soc1c
Copy link
Contributor

@soc1c soc1c commented Jul 9, 2019

Edge-cases in Clique-based networks were discovered that eventually lead the chain to halt. One of the reasons is that some clients publish out-of-turn to the network too fast. EIP-2183 addresses this and encourages clients that implement Clique to streamline their block-authoring logic based on this proposal.

resolves goerli#16

resolves goerli#15

partially replaces #1955

@karalabe
Copy link
Member

This EIP introduces a minimum waiting time for all out of turn blocks, but I'm not sure that alone is enough to solve the issue. If an in-turn signer is offline, we'll have N other out of turn signers all waiting for the exact same period to publish their blocks, and they'll flood the network at that point. Miners could still have the current random wait included too, but if you figured that's not enough for propagation in the first place, then this EIP won't solve the issue properly either.

Hmmm, my other concern with this proposal way back was that I thought that for every out of turn block, you bump the block time to 1.5x. Thinking about it now however I kind of realize that you still keep the same original time stamp, you just publish the block later. So in theory, this will result in a 23 second block out of turn, but then all consecutive out of turn blocks at 15 secs and finally a 7 second block in-turn. So I guess this removes my original concern. However I think this would be important to emphasize in the EIP.

@github-actions
Copy link

github-actions bot commented Sep 8, 2020

There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Sep 8, 2020
@github-actions
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a Clique MIN_WAIT for out-of-turn blocks Force-publish Clique in-turn blocks
4 participants