Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popups close when hitting the Esc key, regardless of the input map #75431

Closed
jbahamon opened this issue Mar 28, 2023 · 4 comments · Fixed by #77297
Closed

Popups close when hitting the Esc key, regardless of the input map #75431

jbahamon opened this issue Mar 28, 2023 · 4 comments · Fixed by #77297

Comments

@jbahamon
Copy link

jbahamon commented Mar 28, 2023

Godot version

v4.0.stable.official [92bee43]

System information

Windows 10

Issue description

Currently, popups can be closed by using the Esc key. But this completely ignores the game's input map. IIRC popups used to have this closing behavior tied to the ui_cancel action, which I think made more sense. I'm guessing it's because of this line, as the Esc key is hardcoded there.

Steps to reproduce

Create a Popup and open it. Even if the input map never references the Esc key, the popup can be closed by pressing the Esc key.

Minimal reproduction project

N/A

@ghost
Copy link

ghost commented Mar 30, 2023

Hi! I'm a first time contributor, may I be assigned to this issue?

@AThousandShips
Copy link
Member

AThousandShips commented Mar 30, 2023

Don't need to be assigned issues here, just open a PR if you have a solution, though this might need some discussion

@YuriSizov
Copy link
Contributor

Does it need a discussion? Seems reasonable to have this respect the ui_cancel action.

@AThousandShips
Copy link
Member

Oh sorry yes should be simple, wasn't sure if linking that was the preferred solution but it is reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment