get_node() does not accept StringName variables as a valid argument

[TisFoolish]

Godot version

4.0 Beta 11

System information

Win 10, Forward+, 1080ti, 516.94 driver

Issue description

Simply put if you try to get a node by using a StringName as an argument you'll get the error

Parser Error: Invalid argument for "get_node()" function: argument 1 should be "NodePath" but is "StringName".

which is likely an oversight because doing get_name() on a node gives a StringName.

I came across this when I was trying to loop through some nodes, checking names of nodes in an array vs the children of a node, but was able to easily work around it by making the array a string typed array

Steps to reproduce

I uploaded an mrp, but the code is as simple as

var nodeString = StringName("Node")
var test = get_node(nodeString)

Minimal reproduction project

bug.zip

[PrecisionRender]

Try test = get_node(NodePath(nodeString)) as a workaround.

[TisFoolish]

Like I said, I just typed the array to String

[thehappycheese]

To give a practical example, I encountered this issue like this (v4.0.stable.official [92bee43]):

var graph_edit:GraphEdit = $"../Panel/VBoxContainer/GraphEdit"
for connection in graph_edit.get_connection_list():
    var graph_node = graph_edit.get_node(connection.from) # <<< ERROR

The solution is to modify graph_edit.get_node(String(connection.from)) which converts from:StringName to from:String allowing it to be automatically coerced to from:NodePath. I would hope that in future StringName would automatically coerce to NodePath as expected, or else graph_edit.get_connection_list() should return {from:NodePath,...}[]

[goatchurchprime]

I've just hit this bug with an @rpc call over a dict where some of the values were randomly arriving as StringNames, in particular the one which held the nodename value.

This weird type is only made visible when you print the whole dict and there's this unexpected '&' after the ':'.

[AThousandShips]

• Related: Add a method to construct a NodePath from a StringName #72702

[shafnaz]

Also getting similar error trying to get a node in a scene.