Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Batch rename window size not updating correctly #52074

Closed
LoipesMas opened this issue Aug 24, 2021 · 3 comments · Fixed by #52690
Closed

[3.x] Batch rename window size not updating correctly #52074

LoipesMas opened this issue Aug 24, 2021 · 3 comments · Fixed by #52690

Comments

@LoipesMas
Copy link
Contributor

Godot version

3.4 5ce734c

System information

Linux

Issue description

When in batch rename window preview text doesn't fit in the window, the window background doesn't scale properly.
Moving the window updates it.

Same thing on 3.3.3, but on master it's fine (because it's a separate window there?).

image

Steps to reproduce

Open batch rename window.
Make so the preview text is so long that it doesn't fit.

Minimal reproduction project

No response

@nsrCodes
Copy link
Contributor

I was trying to fix this by making changes in editor/rename_dialog.cpp
But just turning on autowrap on the preview label was not enough as we also have to increase the height of the VBoxContainer, else, instead of overflowing from the right, it overflows from below.
Screenshot from 2021-09-14 22-39-34

Is there a way to do so? I was expecting to find some sort of update function to call inside the _update_preview function, but so far no luck.

the height is adjusted when the advanced options are toggled, but that too gives weird results.

@nsrCodes
Copy link
Contributor

We could also just clip off the overflow, but that would not show the complete preview to the user (which I guess is not ideal?)
Screenshot from 2021-09-14 22-49-10

@Calinou
Copy link
Member

Calinou commented Sep 14, 2021

We could also just clip off the overflow, but that would not show the complete preview to the user (which I guess is not ideal?)

In the master branch, there are various ellipsis overflow modes available in Label. I'd use one of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants