Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicsServer3D errors when starting new project #46167

Closed
Tracked by #45333
akien-mga opened this issue Feb 18, 2021 · 5 comments
Closed
Tracked by #45333

PhysicsServer3D errors when starting new project #46167

akien-mga opened this issue Feb 18, 2021 · 5 comments
Assignees
Milestone

Comments

@akien-mga
Copy link
Member

akien-mga commented Feb 18, 2021

Godot version:
Current master (actually #46127 so it's not excluded that it may come from that PR - I will test actual master later on).
Edit: Confirmed reproducible on a67a6a5.

OS/device including version:
Linux, Mageia 8

Issue description:
When opening any project (including a brand new one), I get these errors in the terminal:

ERROR: Condition "!shape->is_configured()" is true. Returning: Variant()
   at: shape_get_data (servers/physics_3d/physics_server_3d_sw.cpp:125)
ERROR: Condition "!d.has("cell_size")" is true.
   at: set_data (servers/physics_3d/shape_3d_sw.cpp:1688)
ERROR: Condition "!body" is true.
   at: body_attach_object_instance_id (servers/physics_3d/physics_server_3d_sw.cpp:614)
ERROR: Invalid ID.
   at: free (servers/physics_3d/physics_server_3d_sw.cpp:1322)

Steps to reproduce:

  • Start new project
  • Check terminal

Minimal reproduction project:
Default new project is sufficient.

@Xrayez
Copy link
Contributor

Xrayez commented Feb 18, 2021

The error reminds me of my fix in #32272 (comment), which I fixed locally by now.

@pouleyKetchoupp
Copy link
Contributor

It seems these errors are due to starting the editor with Godot Physics now that Bullet is disabled (from #45852).

They are not really critical as they happen during DocTool generation and won't cause further issues.

The first one needs some investigation to find the proper fix. Here's the callstack:

 	godot.windows.tools.64.exe!PhysicsServer3DSW::shape_get_data(RID p_shape) Line 125	C++
 	godot.windows.tools.64.exe!PhysicsServer3DWrapMT::shape_get_data(RID p1) Line 99	C++
 	godot.windows.tools.64.exe!ConcavePolygonShape3D::get_faces() Line 83	C++
 	godot.windows.tools.64.exe!call_with_variant_args_retc_helper<ConcavePolygonShape3D,Vector<Vector3>>(ConcavePolygonShape3D * p_instance, Vector<Vector3>(const ConcavePolygonShape3D::*)() p_method, const Variant * * p_args, Variant & r_ret, Callable::CallError & r_error, IndexSequence<> __formal) Line 591	C++
 	godot.windows.tools.64.exe!call_with_variant_args_retc_dv<ConcavePolygonShape3D,Vector<Vector3>>(ConcavePolygonShape3D * p_instance, Vector<Vector3>(const ConcavePolygonShape3D::*)() p_method, const Variant * * p_args, int p_argcount, Variant & r_ret, Callable::CallError & r_error, const Vector<Variant> & default_values) Line 431	C++
 	godot.windows.tools.64.exe!MethodBindTRC<ConcavePolygonShape3D,Vector<Vector3>>::call(Object * p_object, const Variant * * p_args, int p_arg_count, Callable::CallError & r_error) Line 544	C++
 	godot.windows.tools.64.exe!ClassDB::get_property(Object * p_object, const StringName & p_property, Variant & r_value) Line 1163	C++
 	godot.windows.tools.64.exe!Object::get(const StringName & p_name, bool * r_valid) Line 456	C++
 	godot.windows.tools.64.exe!ClassDB::class_get_default_property_value(const StringName & p_class, const StringName & p_property, bool * r_valid) Line 1494	C++
 	godot.windows.tools.64.exe!get_documentation_default_value(const StringName & p_class_name, const StringName & p_property_name, bool & r_default_value_valid) Line 210	C++
 	godot.windows.tools.64.exe!DocTools::generate(bool p_basic_types) Line 301	C++

The 3 others will be fixed when heightmaps and soft bodies are implemented in Godot Physics.

@Xrayez
Copy link
Contributor

Xrayez commented Feb 18, 2021

Yes, it's basically the same issue as in #32216, but reproduction steps are different now.

@kalysti
Copy link
Contributor

kalysti commented Apr 22, 2021

@akien-mga that issue come from the HeightmapShapeCollider (cell_size is a required paramter) and is fixed by pouley after updating the "HeightmapShapeCollider" with this pr: https://github.com/godotengine/godot/issues?q=heightmap.

Also fixed with that pr for bullet "#47508".

I therefore think the ticket can be closed.

I hope I could help

@pouleyKetchoupp
Copy link
Contributor

Yes, the last issue was fixed with #47347 so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants