Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Godot shutdown process on Android #31541

Open
m4gr3d opened this issue Aug 21, 2019 · 2 comments
Open

Improve Godot shutdown process on Android #31541

m4gr3d opened this issue Aug 21, 2019 · 2 comments

Comments

@m4gr3d
Copy link
Contributor

m4gr3d commented Aug 21, 2019

Godot version:
Any version < 3.2

OS/device including version:
Android

Issue description:
PR #31521 provides a temp solution to properly shutdown Godot apps on Android by killing the entire app process.
The proper fix involves tracking down the native components that are initialized at startup and properly cleaning them at application shut down.
This is a more involved fix as it might involve multiple refactors across the codebase.

@loddyryons
Copy link

Hi @m4gr3d I'm curious if this is being worked on? Currently on Android when restart is called, it tries to restart the process to clear state, but this obviously means that the application is killed and restarted on the user which isn't ideal.

Relevant code ->

Thanks!

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Aug 18, 2021

Hi @m4gr3d I'm curious if this is being worked on? Currently on Android when restart is called, it tries to restart the process to clear state, but this obviously means that the application is killed and restarted on the user which isn't ideal.

@loddyryons PR #51846 and #51586 improve the state of things by delegating to the Godot host instead. This way the default behavior can be overwritten where appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants