Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ambiguous naming of 'layers' in TileSets #3879

Open
snailrhymer opened this issue Jan 27, 2022 · 2 comments
Open

Resolve ambiguous naming of 'layers' in TileSets #3879

snailrhymer opened this issue Jan 27, 2022 · 2 comments
Labels
breaks compat Proposal will inevitably break compatibility topic:editor topic:physics topic:2d
Milestone

Comments

@snailrhymer
Copy link

snailrhymer commented Jan 27, 2022

Describe the project you are working on

Generic TileMap workflow, thinking particularly about new users' experiences (related to discussion on #1769).

Describe the problem or limitation you are having in your project

Currently, TileSet uses the terms 'Physics Layer', 'Occlusion Layer' etc. This is likely to cause confusion, particularly with new users. For example, a Physics Layer in this context specifies (in part) which Collision Layers a tile will belong to. Elsewhere, the layer that collision layer refers to here, is called a physics layer:
image

and likewise for the navigation layers:

image

It's easy to imagine many TileMap tutorials will state something along the lines of "you might think that Physics Layer means X, when really it means Y", which I think is a situation best avoided. It's true that once users have spent some time with these, they'll have a better understanding of what is actually going on. There's nevertheless the risk that users will either avoid using these very powerful tools because they find them unapproachable, or that they sink time into setting them up incorrectly because they've misunderstood the terminology.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Use different terminology to refer to these meta layers/layer groups. Unfortunately, I don't have any firm ideas on this front - proposals are welcomed below.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Old name -> New name

If this enhancement will not be used often, can it be worked around with a few lines of script?

The workaround would be getting familiar with the systems, which arguably isn't a massive price to pay to use the systems. If it's possible to cut down on misunderstandings by renaming, that still seems preferable.

Is there a reason why this should be core and not an add-on in the asset library?

It's a key part of the TileMap workflow.

@snailrhymer
Copy link
Author

'Physics Behaviour' feels like it might cover the collision layer, collision mask and physics material settings nicely, and a quick search doesn't reveal anything it clashes with.

@Calinou Calinou added this to the 4.0 milestone Jan 27, 2022
@Calinou Calinou added the breaks compat Proposal will inevitably break compatibility label May 15, 2022
@aaronfranke aaronfranke modified the milestones: 4.0, 5.0 Feb 24, 2023
@Mickeon
Copy link

Mickeon commented Jun 28, 2024

4.3 completely deprecates TileMap (one or more layers) in favour of one or more TileMapLayer nodes, which is more inline with Godot's node hierarchy design. This by itself should reduce the confusion by a large margin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks compat Proposal will inevitably break compatibility topic:editor topic:physics topic:2d
Projects
None yet
Development

No branches or pull requests

4 participants