Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more editor shortcuts #293

Closed
ron0studios opened this issue Dec 9, 2019 · 4 comments
Closed

Add more editor shortcuts #293

ron0studios opened this issue Dec 9, 2019 · 4 comments
Milestone

Comments

@ron0studios
Copy link

Describe the project you are working on:
I am working on a 2d platformer featuring lighting and building mechanics.

Describe the problem or limitation you are having in your project:
certain shortcuts that do exist in most software such as a rename shortcut or to "change type" etc. do not exist on the Godot engine. When working on a project, such annoyances tend to build up and for speed programmers and users working against a deadline this is also an issue.

Describe how this feature / enhancement will help you overcome this problem or limitation:
Introducing more shortcuts in different aspects of Godot greatly increases the flexibility and ease for beginners and professionals working on a certain project. It also opens new possibilities for people wanting to submit or create projects for game jams.

Show a mock up screenshots/video or a flow diagram explaining how your proposal will work:
Godot Engine - Infeinermium (_) 09_12_2019 18_00_27

Describe implementation detail for your proposal (in code), if possible:
I do not have much experience with github or contributing to code, but i can say that this is quite an easy feature to implement. If other shortcuts could be implemented, performing an action when a certain combination of keys are pressed, surely adding a few more should not be difficult?

If this enhancement will not be used often, can it be worked around with a few lines of script?:
this enhancement could be altered or even removed in a settings tab

Is there a reason why this should be core and not an add-on in the asset library?:
having a few extra shortcuts SHOULD NOT be an addon. Firstly, it is such a principle mechanic, that it should not require the user to download. Alongside this, for people who are switching engines to Godot or wanting to rate and compare the engine with others, they should not have to go through the effort to download a mechanic like this.

@Calinou
Copy link
Member

Calinou commented Dec 9, 2019

I'm not sure if Ctrl + R would be a good fit for renaming. We can't use F2 either, as it's already used to switch to the 2D editor (unless we rebind that to another key).

Any suggestions for the Change Type and Make Scene Root shortcuts?

@KoBeWi
Copy link
Member

KoBeWi commented Dec 9, 2019

You can already rename nodes by pressing Enter.

btw, you can already add shortcuts for these actions in Editor Settings, no? They just don't have defaults.

@golddotasksquestions
Copy link

golddotasksquestions commented Dec 14, 2019

@Calinou

Any suggestions for the Change Type and Make Scene Root shortcuts?

Why not let OP set their own? I suppose OP did not know they could do so by go to Editor > Editor Settings > Shortcuts then type the command into the search field.
Neither did I know I could do this until another user told me so (possibly you Calinou or KoBeWi), I always just clicked RMB and saw some had shortcuts and other had not, and that was it. The Shortcut panel in the Editor settings is also really easy to miss. Even after I have been told were it was. It needed someone to point me there exactly for me to find it. Is this the case for you as well @rudrrayan ?

Personally I think it's actually a good thing that those less common things don't have predefined shortcuts but allow the user to set their preferred shortcut any time.

I clearly remember when I started learning Maya and everything already had a predefined shortcut. Often I found those not intuitive or practical and tried to change them. But since pretty much every key combination was already taken, you were always confronted with a prompt asking: "This shortcut is already taken. Do you really want to set this shortcut and remove this other one?"
If you did, then of course the other functionality suddenly had no shortcut at all anymore. This meant I would have to "replace" those as well, which lead to a never ending Penrose Stair cascade of shortcut changing.
Even if you don't fall into this pit, the question "should I really change this shortcut and with it destroy another?" can be quite irritating. At least for me it was, because I was afraid I would have a harder time to follow tutorials, if I change too much. Yes there is the ability to reset to default shortcuts (not Godot), and yes some editors have the ability to export and import shortcuts settings (not Godot), but even if I had those options I became more apprehensive to improve my work environment to my needs because the Editor was filled to the brim with predefined shortcuts and I as a beginner did not know which are the important ones and which are not.

But in general, I think it would be great having the option to assign a shortcut to pretty much everything one can do in Godot.
Aseprite has an amazing shortcut menu, if someone who wants to work on this is looking for inspiration.

@Calinou Calinou changed the title Add more Shortcuts! Add more editor Shortcuts Jun 19, 2020
@Calinou Calinou changed the title Add more editor Shortcuts Add more editor shortcuts Jun 19, 2020
@Calinou
Copy link
Member

Calinou commented Jun 20, 2020

As of Godot 3.2.1, Rename, Change Type and Make Scene Root can all have shortcuts configured in the Editor Settings. For example:

image

image

Rename may be bound to F2 by default in Godot 4.0 (see godotengine/godot#38201).

I'll close this since the proposal has been implemented.

@Calinou Calinou closed this as completed Jun 20, 2020
@aaronfranke aaronfranke added this to the 3.2 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants