Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationPlayer track: track visualisation should also visualize Update Mode, Interpolation Mode or Easing #289

Closed
golddotasksquestions opened this issue Dec 7, 2019 · 0 comments · Fixed by godotengine/godot#47230
Milestone

Comments

@golddotasksquestions
Copy link

golddotasksquestions commented Dec 7, 2019

Describe the project you are working on: Projects that use AnimationPlayer node a lot.

Describe the problem or limitation you are having in your project:
I was on the fence submitting the track visualization as bug, because it leads to false judgement and shows stuff that is not actually happening:
When you change alpha or color between two keys, the track accurately visualizes the change (see alpha -> white -> alpha -> red transition below). However, when you change Update Mode, Interpolation Mode or Easing, the track visualization dos not reflect the setting, which makes it very easy to oversee a mistake, or simply confuse people. This makes the track visualization imho more harmful than helpful:
animation_track_previs

Describe how this feature / enhancement will help you overcome this problem or limitation:
Make the track reflect the Update Mode, Interpolation Mode or Easing setting as well, or remove the track visualization all together.

Show a mock up screenshots/video or a flow diagram explaining how your proposal will work:
See above how it currently works. If the track visualization would also reflect Update Mode, Interpolation Mode or Easing setting, we would not see a gradient between keys on the track once I changed the setting from "linear" to "Nearest" (Interpolation Mode), or "Linear" to "Zero" (Easing)

Describe implementation detail for your proposal (in code), if possible:
Impossible.

If this enhancement will not be used often, can it be worked around with a few lines of script?:
Not that I would know.

Is there a reason why this should be core and not an add-on in the asset library?:
It would lead to less confusion and potential error for all users of the AnimationPlayer. Don't download anti-confusion medicine in the library, people!

@golddotasksquestions golddotasksquestions changed the title AnimationPlayer track: track previsualisation should also visualise Update Mode, Interpolation Mode or Easing AnimationPlayer track: track visualisation should also visualise Update Mode, Interpolation Mode or Easing Dec 7, 2019
@golddotasksquestions golddotasksquestions changed the title AnimationPlayer track: track visualisation should also visualise Update Mode, Interpolation Mode or Easing AnimationPlayer track: track visualisation should also visualize Update Mode, Interpolation Mode or Easing Dec 7, 2019
@Calinou Calinou added this to the 4.0 milestone Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants