Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expand): parameters & responses should properly follow remote doc resolution when SKipSchema #183

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

… resolution when SKipSchema

* fixes go-openapi#182
* contributes go-swagger/go-swagger#2743

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b445199) 64.78% compared to head (0bf0cbc) 65.43%.

Files Patch % Lines
expander.go 75.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   64.78%   65.43%   +0.65%     
==========================================
  Files          29       29              
  Lines        2845     2844       -1     
==========================================
+ Hits         1843     1861      +18     
+ Misses        833      820      -13     
+ Partials      169      163       -6     
Flag Coverage Δ
oldstable 65.43% <75.00%> (+0.65%) ⬆️
stable 65.43% <75.00%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
Copy link
Member Author

fredbi commented Jan 8, 2024

@casualjim @youyuanwu

Added PRs with additional testing in known repos using this feature:

Seems to work, even if tinkering with this part has always been a bit dodgy...

@fredbi fredbi merged commit ed00e71 into go-openapi:master Jan 9, 2024
10 checks passed
@fredbi fredbi deleted the fix/2743 branch January 9, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expander: when expanding with SkipSchema, the relative path is lost
2 participants