From 456ce29a962cb27ce5a3806614e551d5bb093dc2 Mon Sep 17 00:00:00 2001 From: "Panagiotis \"Ivory\" Vasilopoulos" Date: Thu, 7 Dec 2023 02:32:17 +0100 Subject: [PATCH 1/2] Issue fixes for RSS feed improvements Follow-up for #28368 - Just replace button with an a-element with the button class - Use role=button for screen readers - Remove useless link-action class from template/org/home.tmpl --- templates/org/home.tmpl | 4 ++-- templates/repo/header.tmpl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/org/home.tmpl b/templates/org/home.tmpl index a84e3efc89de..f0bf628aea62 100644 --- a/templates/org/home.tmpl +++ b/templates/org/home.tmpl @@ -21,9 +21,9 @@
{{if .EnableFeed}} - + {{end}} + {{end}}
{{$.CsrfTokenHtml}} From 5661e2e65ab8a3126a1bf60ac173e76cbdafa512 Mon Sep 17 00:00:00 2001 From: "Panagiotis \"Ivory\" Vasilopoulos" Date: Thu, 7 Dec 2023 02:55:44 +0100 Subject: [PATCH 2/2] remove role button --- templates/org/home.tmpl | 2 +- templates/repo/header.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/org/home.tmpl b/templates/org/home.tmpl index f0bf628aea62..fc65d4691cbe 100644 --- a/templates/org/home.tmpl +++ b/templates/org/home.tmpl @@ -21,7 +21,7 @@
{{if .EnableFeed}} - + {{svg "octicon-rss" 24}} {{end}} diff --git a/templates/repo/header.tmpl b/templates/repo/header.tmpl index 279be4207e42..af00b2b3831e 100644 --- a/templates/repo/header.tmpl +++ b/templates/repo/header.tmpl @@ -54,7 +54,7 @@ {{end}} {{if $.EnableFeed}} {{/* An extra div-element is not necessary here, as this button does not secretly contain two buttons. */}} - + {{svg "octicon-rss" 16}} {{end}}