From 58f2db760a30b77daa3ff76afa64138228c24d1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ville=20Skytt=C3=A4?= Date: Wed, 10 Apr 2024 23:47:21 +0300 Subject: [PATCH] cmd/dlv: fix panic on connect fail --- cmd/dlv/cmds/commands.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/dlv/cmds/commands.go b/cmd/dlv/cmds/commands.go index db8935922e..80865398d3 100644 --- a/cmd/dlv/cmds/commands.go +++ b/cmd/dlv/cmds/commands.go @@ -936,7 +936,9 @@ func connect(addr string, clientConn net.Conn, conf *config.Config) int { // Create and start a terminal - attach to running instance var client *rpc2.RPCClient if clientConn == nil { - clientConn = netDial(addr) + if clientConn = netDial(addr); clientConn == nil { + return 1 // already logged + } } client = rpc2.NewClientFromConn(clientConn) if client.IsMulticlient() {