Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review #1

Open
boatcoder opened this issue May 11, 2023 · 0 comments
Open

Code Review #1

boatcoder opened this issue May 11, 2023 · 0 comments

Comments

@boatcoder
Copy link

if hasattr(request, 'cparam'):
        for k, v in request.cparam.items():
            params.append('{0}={1}'.format(k, v))

Doesn't take into account potential need for v to urlencoded....

Might be better to clone the QueryDict that is GET with mutable=True and update the QueryDict and urlencode the final result. This would also allow you to replace params vs just append params to the end of the URL....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant