From d436710630fba3352c84b99407b4868eb8c34efa Mon Sep 17 00:00:00 2001 From: Ivan Dyachkov Date: Mon, 7 Aug 2023 18:23:15 +0200 Subject: [PATCH 1/2] fix: fix time to first response --- time_to_first_response.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/time_to_first_response.py b/time_to_first_response.py index 204b209..5cf2532 100644 --- a/time_to_first_response.py +++ b/time_to_first_response.py @@ -56,6 +56,7 @@ def measure_time_to_first_response( if comment.user.login in ignore_users: continue first_comment_time = comment.created_at + break # Check if the issue is actually a pull request # so we may also get the first review comment time @@ -66,6 +67,7 @@ def measure_time_to_first_response( if review_comment.user.login in ignore_users: continue first_review_comment_time = review_comment.submitted_at + break # Figure out the earliest response timestamp if first_comment_time and first_review_comment_time: From 3d63f986a53df04c35e8b5828bdd3546baa19162 Mon Sep 17 00:00:00 2001 From: Zack Koppert Date: Mon, 7 Aug 2023 11:40:15 -0700 Subject: [PATCH 2/2] test for comment times being overwritten Signed-off-by: Zack Koppert --- test_time_to_first_response.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/test_time_to_first_response.py b/test_time_to_first_response.py index 0cd4843..96db75d 100644 --- a/test_time_to_first_response.py +++ b/test_time_to_first_response.py @@ -33,12 +33,14 @@ def test_measure_time_to_first_response(self): """ # Set up the mock GitHub issues mock_issue1 = MagicMock() - mock_issue1.comments = 1 + mock_issue1.comments = 2 mock_issue1.created_at = "2023-01-01T00:00:00Z" mock_comment1 = MagicMock() mock_comment1.created_at = datetime.fromisoformat("2023-01-02T00:00:00Z") - mock_issue1.issue.comments.return_value = [mock_comment1] + mock_comment2 = MagicMock() + mock_comment2.created_at = datetime.fromisoformat("2023-01-02T12:00:00Z") + mock_issue1.issue.comments.return_value = [mock_comment1, mock_comment2] # Call the function result = measure_time_to_first_response(mock_issue1, None) @@ -105,7 +107,9 @@ def test_measure_time_to_first_response_only_ignored_users(self): mock_issue1.issue.comments.return_value = [mock_comment1, mock_comment2] # Call the function - result = measure_time_to_first_response(mock_issue1, None, ["ignored_user", "ignored_user2"]) + result = measure_time_to_first_response( + mock_issue1, None, ["ignored_user", "ignored_user2"] + ) expected_result = None # Check the results