From 83f128cbc81c3699646d379821223f248f16e798 Mon Sep 17 00:00:00 2001 From: Dave Hirschfeld Date: Tue, 16 Jan 2024 14:59:01 +1100 Subject: [PATCH 1/2] Update adding-a-new-ssh-key-to-your-github-account.md Add example of adding a signing key --- .../adding-a-new-ssh-key-to-your-github-account.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/content/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account.md b/content/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account.md index 7ce8f8a6f5e8..27dff9496fdd 100644 --- a/content/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account.md +++ b/content/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account.md @@ -63,12 +63,10 @@ After adding a new SSH authentication key to your account on {% ifversion ghae % Before you can use the {% data variables.product.prodname_cli %} to add an SSH key to your account, you must authenticate to the {% data variables.product.prodname_cli %}. For more information, see [`gh auth login`](https://cli.github.com/manual/gh_auth_login) in the {% data variables.product.prodname_cli %} documentation. -{% ifversion ssh-commit-verification %}At present, you can only use {% data variables.product.prodname_cli %} to add SSH authentication keys, you cannot add SSH signing keys.{% endif %} - To add an SSH authentication key to your GitHub account, use the `ssh-key add` subcommand, specifying your public key. If you're prompted to request additional scopes, follow the instructions in the command line. ```shell -gh ssh-key add KEY-FILE +gh ssh-key add KEY-FILE --type {authentication|signing} ``` To include a title for the new key, use the `-t` or `--title` flag. @@ -80,7 +78,7 @@ gh ssh-key add KEY-FILE --title "personal laptop" If you generated your SSH key by following the instructions in "[AUTOTITLE](/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent)", you can add the key to your account with this command. ```shell -gh ssh-key add ~/.ssh/id_ed25519.pub +gh ssh-key add ~/.ssh/id_ed25519.pub --type signing ``` {% endcli %} From 8ff5bec8b83b190754c054717e7bca243bf15254 Mon Sep 17 00:00:00 2001 From: Dave Hirschfeld Date: Wed, 17 Jan 2024 16:36:14 +1100 Subject: [PATCH 2/2] Improve wording --- .../adding-a-new-ssh-key-to-your-github-account.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account.md b/content/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account.md index 27dff9496fdd..d59fe78bac4d 100644 --- a/content/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account.md +++ b/content/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account.md @@ -63,7 +63,7 @@ After adding a new SSH authentication key to your account on {% ifversion ghae % Before you can use the {% data variables.product.prodname_cli %} to add an SSH key to your account, you must authenticate to the {% data variables.product.prodname_cli %}. For more information, see [`gh auth login`](https://cli.github.com/manual/gh_auth_login) in the {% data variables.product.prodname_cli %} documentation. -To add an SSH authentication key to your GitHub account, use the `ssh-key add` subcommand, specifying your public key. If you're prompted to request additional scopes, follow the instructions in the command line. +To add an SSH key to your GitHub account, use the `ssh-key add` subcommand, specifying your public key. For authentication keys, if you're prompted to request additional scopes, follow the instructions in the command line. ```shell gh ssh-key add KEY-FILE --type {authentication|signing}