From 2af7207f47c26056006dcad0c27b495165fa3df6 Mon Sep 17 00:00:00 2001 From: Philipp Hofmann Date: Mon, 10 Jul 2023 18:58:52 +0200 Subject: [PATCH] feat(sdk-crashes): Set SDK version as release (#52501) Set SDK version as release to understand on which SDK versions the SDK crashes occur. --- src/sentry/utils/sdk_crashes/sdk_crash_detection.py | 3 +++ tests/sentry/utils/sdk_crashes/test_sdk_crash_detection.py | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/sentry/utils/sdk_crashes/sdk_crash_detection.py b/src/sentry/utils/sdk_crashes/sdk_crash_detection.py index 5ecd81c632af6..a57601f958e78 100644 --- a/src/sentry/utils/sdk_crashes/sdk_crash_detection.py +++ b/src/sentry/utils/sdk_crashes/sdk_crash_detection.py @@ -65,6 +65,9 @@ def detect_sdk_crash( }, ) + sdk_version = get_path(sdk_crash_event_data, "sdk", "version") + set_path(sdk_crash_event_data, "release", value=sdk_version) + # So Sentry can tell how many projects are impacted by this SDK crash set_path(sdk_crash_event_data, "user", "id", value=event.project.id) diff --git a/tests/sentry/utils/sdk_crashes/test_sdk_crash_detection.py b/tests/sentry/utils/sdk_crashes/test_sdk_crash_detection.py index 2242077b48e9d..dfdae6f61ea22 100644 --- a/tests/sentry/utils/sdk_crashes/test_sdk_crash_detection.py +++ b/tests/sentry/utils/sdk_crashes/test_sdk_crash_detection.py @@ -54,6 +54,8 @@ def execute_test(self, event_data, should_be_reported, mock_sdk_crash_reporter): assert reported_event_data["user"] == { "id": event.project_id, } + + assert reported_event_data["release"] == get_path(event_data, "sdk", "version") else: assert mock_sdk_crash_reporter.report.call_count == 0