Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing without performance improvements #862

Merged
merged 17 commits into from
Sep 4, 2024

Conversation

cleptric
Copy link
Member

No description provided.

@cleptric cleptric self-assigned this Jul 22, 2024
@cleptric cleptric force-pushed the tracing-without-performance-fixes branch from 4194276 to 0d01892 Compare July 22, 2024 11:23
@cleptric cleptric force-pushed the tracing-without-performance-fixes branch from e7f5b13 to 35092b3 Compare August 15, 2024 04:28
// create one from the properties of the transaction.
if !s.dynamicSamplingContext.IsFrozen() {
// This will return a frozen DynamicSamplingContext.
if dsc := DynamicSamplingContextFromTransaction(t); dsc.HasEntries() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cleptric Not sure if this will cause unwanted changes, but it did fix the failing test because it was setting the dynamicSamplingContext to "" due to nil client.

@ribice
Copy link
Collaborator

ribice commented Aug 27, 2024

I fixed the gin panic issue. But with these changes, in gin, the request body is not properly set on the event. I'll keep debugging this.

@ribice
Copy link
Collaborator

ribice commented Aug 28, 2024

I fixed the gin panic issue. But with these changes, in gin, the request body is not properly set on the event. I'll keep debugging this.

Resolved.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (7085a1d) to head (c6927fb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gin/sentrygin.go 53.84% 6 Missing ⚠️
tracing.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
- Coverage   82.90%   82.79%   -0.11%     
==========================================
  Files          55       55              
  Lines        4603     4610       +7     
==========================================
+ Hits         3816     3817       +1     
- Misses        633      636       +3     
- Partials      154      157       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric marked this pull request as ready for review September 3, 2024 09:26
@cleptric cleptric requested a review from ribice September 3, 2024 10:20
hub.go Show resolved Hide resolved
@cleptric cleptric merged commit 24ffea5 into master Sep 4, 2024
25 checks passed
@cleptric cleptric deleted the tracing-without-performance-fixes branch September 4, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants