Set filename when calling the /results endpoint directly

[arikfr]

Probably by using the Content-Disposition header.

[aidarbek]

Hi! I am new to the project, could you clarify few things? As far as I understood, the https://github.com/getredash/redash/blob/master/redash/handlers/query_results.py file (QueryResultResource class) should be changed and Content-Disposition header should be added to response containing xlsx, csv and json files. What the name of the file should be? Can it be query_result_id or query_id variables?

[arikfr]

Hi @aidarbek, welcome :)

This is how we generate the filename on the frontend:

redash/client/app/components/queries/query-results-link.js

Lines 27 to 28 in ff42ec2

	`${scope.query.name.replace(/ /g, '_') +
	moment(scope.queryResult.getUpdatedAt()).format('_YYYY_MM_DD')}.${fileType}`,

Basically: query name (spaces replaced with _) + date of query result execution + file extension.

I guess we can do the same?

[arikfr]

Implemented in #3359 by @aidarbek 🙇