Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend stack #1125

Closed
arikfr opened this issue Jun 14, 2016 · 7 comments · Fixed by #1376
Closed

Upgrade frontend stack #1125

arikfr opened this issue Jun 14, 2016 · 7 comments · Fixed by #1376

Comments

@arikfr
Copy link
Member

arikfr commented Jun 14, 2016

Our frontend stack is becoming more and more outdated which makes keeping up with best practices harder. Once we start actually working on this, we should probably split this into multiple steps.

  1. Upgrade to Angular 1.5 (we're on 1.2 at the moment...).
  2. Switch to using npm and Webpack instead of Bower & Gulp. We can consider using SystemJS, but looks like Webpack is industry standard, so probably better to stick to it.
  3. Implement latest style guide -- mainly rewrite all our directives as components, remove controllers, etc.
  4. Reduce dependency on Angular specific stuff (angular.module, service, etc) by using regular Javascript modules.
  5. ... significant time later ... Rewrite all components as React components 😝 .
@ninneko
Copy link
Contributor

ninneko commented Jun 23, 2016

I feel it hard to understand frontend codes, so I will be happy when refactor frontend codes.

@arikfr
Copy link
Member Author

arikfr commented Aug 18, 2016

@eiso
Copy link

eiso commented Oct 27, 2016

@arikfr I saw you're about to work on this, out of curiosity are you switching to yarn instead of npm?

@arikfr
Copy link
Member Author

arikfr commented Oct 27, 2016

@eiso not sure. I might give it a try and if it just works will try to use it, but it's less of a priority right now.

@danlg
Copy link

danlg commented May 19, 2017

@arikfr ... Rewrite all components as React components.. at least one so that people who want to contribute and add react component in a plugin manner like grafana in redash can do it. You should reopen this issue as this is not finished.

@oliviertassinari
Copy link

... significant time later ... Rewrite all components as React components stuck_out_tongue_closed_eyes .

It's never too late to use React 👌.

@kravets-levko
Copy link
Collaborator

It's never too late to use React

@oliviertassinari It's already in progress 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants