Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add support for background locations in audit #219

Closed
yanokwa opened this issue Jan 14, 2019 · 6 comments
Closed

Proposal: Add support for background locations in audit #219

yanokwa opened this issue Jan 14, 2019 · 6 comments

Comments

@yanokwa
Copy link
Member

yanokwa commented Jan 14, 2019

In the XForms spec audit is placed in the meta block under the orx namespace. It uses a binary data type. See opendatakit/xforms-spec#94

<orx:meta>
	<orx:audit/>
</orx:meta>
<bind nodeset="/orx:meta/orx:audit" type="binary"/>

I propose we add the following bind attributes in the odk namespace to the specification. All three attributes are required to enable location audits and location-age must be greater than or equal to location-interval.

<bind nodeset="/orx:meta/orx:audit" type="binary" 
           odk:location-priority="balanced" odk:location-min-interval="10" odk:location-max-age="60" />

We have an implementation for Collect at getodk/collect#2772

@yanokwa yanokwa changed the title Proposal: Add support for background locations Proposal: Add support for background locations in audit Jan 14, 2019
@yanokwa
Copy link
Member Author

yanokwa commented Jan 17, 2019

@MartijnR @tiritea Any immediate reactions to this proposal?

@tiritea
Copy link

tiritea commented Jan 17, 2019

Other than putting on my tinfoil hat, nothing from me... ;-)

@MartijnR
Copy link
Contributor

Looks great to me!

@yanokwa
Copy link
Member Author

yanokwa commented Jan 23, 2019

@MartijnR Do you ever see Enketo adding this feature? I ask because if it's possible, I want to make sure we've named things sensibly. @tiritea, same question.

@tiritea
Copy link

tiritea commented Jan 23, 2019

Unfortunately, I'm WAAAAY too late to the #94 party, so I'll have to defer to y'alls expertise that this <meta> stuff is the best place to persist such data :-) [personally, I'm not terribly fond of <meta>, but that's just me...].

In regards to actual naming, I'm easy; so long at all the required parameters are defined.

And as @MartijnR said, I've got far more pressing things to catch up on (repeat groups!) before I can even start to worry about background audits, sigh.

@MartijnR
Copy link
Contributor

I am not seeing this (and other audit) feature getting into Enketo due to the difficulties in mimicking the same events in web clients, coupled with the lack of demand so far, but if that is resolved and changes, these attribute names make sense. They are prefixed with location- which is very sensible, and properly name-spaced. Not sure what location-priority does, but trust this makes sense and is logical. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants