Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field-list appears when deleting repeat with no field-list #1032

Closed
yanokwa opened this issue May 18, 2017 · 2 comments · Fixed by #1034
Closed

Field-list appears when deleting repeat with no field-list #1032

yanokwa opened this issue May 18, 2017 · 2 comments · Fixed by #1034
Labels
bug high priority Should be looked at before other PRs/issues

Comments

@yanokwa
Copy link
Member

yanokwa commented May 18, 2017

Software and hardware versions

Collect v1.6.0

Steps to reproduce the problem

Download this form: delete-transform.xlsx

There are three fixed repeats in this form. Enter unique data for text a, repeat 1 (text b and c) and repeat 2 (text b and c). Go back to repeat 1's text b. Long press on the label and remove the group.

You will be shown a field-list. This unexpected because there are no field-lists in the form. This behavior does not happen in ODK Collect 1.4.10 and my guess is it was introduced in #274.

Probably related to #1033.

@yanokwa yanokwa added the bug label May 18, 2017
@lognaturel
Copy link
Member

lognaturel commented May 18, 2017

This is not quite related to this issue but it seems perhaps it shouldn't be possible to delete a repeat when a jr:count was specified. Currently the UI makes it look like a repeat was deleted but in fact it wasn't. After the form is closed and reopened, there's an empty group at the end. We should look into improving that for #809.

@yanokwa yanokwa changed the title Field-list appears when deleting group with no field-list Field-list appears when deleting repeat with no field-list May 18, 2017
@yanokwa yanokwa added the high priority Should be looked at before other PRs/issues label May 18, 2017
@grzesiek2010
Copy link
Member

@lognaturel

This is not quite related to this issue but it seems perhaps it shouldn't be possible to delete a repeat when a jr:count was specified

you can remove group but then a new one is added automatically at the end so you still have the same number of groups, I think it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants