Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Split plot.py into smaller modules and move these into gcpy/plot #261

Closed
yantosca opened this issue Sep 18, 2023 · 1 comment · Fixed by #263
Closed

[FEATURE REQUEST] Split plot.py into smaller modules and move these into gcpy/plot #261

yantosca opened this issue Sep 18, 2023 · 1 comment · Fixed by #263
Assignees
@yantosca
Labels
category: Feature Request New feature or request topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates)

Comments

@yantosca
Copy link
Contributor

GCPy's plotting routines are all contained within a single large routine that is hard to maintain. We propose splitting the plotting functionality up into smaller modules such as:

  • six_plot.py
  • single_panel.py
  • compare_single_level.py
  • compare_zonal_mean.py

These smaller modules could be moved into a new gcpy/plot folder, and can be imported into existing code in the same way they are now, e.g.

from gcpy.plot import compare_single_panel
from gcpy.plot import compare_zonal_mean

etc.
@yantosca yantosca added category: Feature Request New feature or request topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates) labels Sep 18, 2023
@yantosca yantosca self-assigned this Sep 18, 2023
@yantosca yantosca linked a pull request Sep 21, 2023 that will close this issue
Abstract routines out of gcpy/plot.py into smaller modules within the gcpy/plot folder #263
Merged
@yantosca
Copy link
Contributor Author

PR #263 has now been merged into the GCPy 1.4.0 development stream. We can close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yantosca yantosca

Labels
category: Feature Request New feature or request topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abstract routines out of gcpy/plot.py into smaller modules within the gcpy/plot folder geoschem/gcpy
1 participant
@yantosca