Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Hydrodynamics plugin #1273

Closed
chapulina opened this issue Jan 6, 2022 · 1 comment · Fixed by #1617
Closed

Add tests for Hydrodynamics plugin #1273

chapulina opened this issue Jan 6, 2022 · 1 comment · Fixed by #1617
Assignees
Labels
enhancement New feature or request tests Broken or missing tests / testing infra

Comments

@chapulina
Copy link
Contributor

The plugin was added in #749 without tests. Since then, we've forked the plugin upstream in https://github.com/osrf/lrauv/blob/main/lrauv_ignition_plugins/src/HydrodynamicsPlugin.hh and made tweaks to fix bugs in the code. We should eventually port those fixes here and add tests verifying that the plugin behaves as expected.

Desired behavior

A new integration test that tests various aspects of the hydrodynamics plugin.

Implementation suggestion

The test should verify the hydrodynamics in isolation, so we're sure we're testing the effects of that plugin. Some ideas on how to do that:

  • Set gravity to zero so we don't need buoyancy or a ground plane (that's similar to the Thruster tests added in Thruster plugin: add tests and velocity control #1190 )
  • Apply forces / velocities directly to the vehicle without using extra plugins
  • Measure the theoretical resulting velocities and accelerations based on the provided parameters

Additional context

@chapulina chapulina added enhancement New feature or request tests Broken or missing tests / testing infra labels Jan 6, 2022
@arjo129 arjo129 self-assigned this Jan 10, 2022
@arjo129
Copy link
Contributor

arjo129 commented Jan 10, 2022

For further information purposes and future reference the following lecture notes provide the necessary steps for computing added mass of simple shapes

@quarkytale quarkytale linked a pull request Jul 27, 2022 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants