Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature to allow runtime changes to joint limits #96

Closed
peci1 opened this issue Aug 17, 2020 · 3 comments
Closed

Add Feature to allow runtime changes to joint limits #96

peci1 opened this issue Aug 17, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@peci1
Copy link
Contributor

peci1 commented Aug 17, 2020

I'd like to change <limit><velocity> and <limit><effort> dynamically during the simulation. Currently, it seems that these values are only read when parsing the model.

I've tried this, but changing the component data has no effect:

auto axisComponent = _ecm.Component<components::JointAxis>(this->joint);
axisComponent->Data().SetEffort(2.0);

I also tried re-creating the component, but that also doesn't change the physics engine behavior:

auto axisComponent = _ecm.Component<components::JointAxis>(this->joint);
axisComponent->Data().SetEffort(torque);
components::JointAxis axis(axisComponent->Data());
*axisComponent = axis;
@scpeters
Copy link
Member

Your code snippets are from ign-gazebo, but this is an issue with ign-physics because there is no Feature that exposes joint limits via the API.

@scpeters scpeters changed the title Allow runtime changes to joint limits Add Feature to allow runtime changes to joint limits Aug 20, 2020
@scpeters
Copy link
Member

I think a Feature API could be added to Joint.hh

@chapulina chapulina added help wanted Extra attention is needed enhancement New feature or request labels Sep 21, 2020
@scpeters
Copy link
Member

feature was added in #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants