Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim_telarray/CORSIKA output file names are different to current productions #1133

Open
orelgueta opened this issue Sep 11, 2024 · 6 comments
Assignees

Comments

@orelgueta
Copy link
Contributor

After the refactoring the filenames have a different structure than in the current official productions. Check if going back to the old style does not introduce complications in the code.

@orelgueta orelgueta self-assigned this Sep 11, 2024
@GernotMaier
Copy link
Contributor

At least some of the changes are result of trying to have a consistent naming of output files for all simtools. There had been minor differences between e.g., the ray tracing tools and the naming of files in productions.

The old style is definitely not more complicated, but it would be if files generated by the simulation pipeline follow a consistent naming pattern. Maybe we can improve how we use the routines in names.py.

@orelgueta
Copy link
Contributor Author

One inconsistency was on purpose, the difference between CORSIKA output files and sim_telarray output files. However, that inconsistency we don't have to keep. What I would like to go back to is that the particle name is the first part of the file name. Event if that means it won't be the same as the ray-tracing tool, I think it's still worth it.

@GernotMaier
Copy link
Contributor

This is fine with me - can you remind us how it was before and how it is now?

@orelgueta
Copy link
Contributor Author

  • production: gamma_20deg_180deg_run000001___cta-prod6-2156m-LaPalma-dark.simtel.zst
  • simtools: run000001_gamma_za20deg_azm180deg_North_alpha_label.zst

My suggestion is:

  • gamma_run000001_za20deg_azm180deg_North_alpha_label.simtel.zst

My assumption is that the label will contain the NSB level and perhaps additional info.

@GernotMaier
Copy link
Contributor

My suggestion would to use this then in general for files of this type generated by simtools (and for ray tracing results, we replace gamma by e.g., psf or something similar).

@orelgueta
Copy link
Contributor Author

Sounds good, I will try to do that wherever possible (once I finish with the current project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants