-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sim_telarray/CORSIKA output file names are different to current productions #1133
Comments
At least some of the changes are result of trying to have a consistent naming of output files for all simtools. There had been minor differences between e.g., the ray tracing tools and the naming of files in productions. The old style is definitely not more complicated, but it would be if files generated by the simulation pipeline follow a consistent naming pattern. Maybe we can improve how we use the routines in |
One inconsistency was on purpose, the difference between CORSIKA output files and sim_telarray output files. However, that inconsistency we don't have to keep. What I would like to go back to is that the particle name is the first part of the file name. Event if that means it won't be the same as the ray-tracing tool, I think it's still worth it. |
This is fine with me - can you remind us how it was before and how it is now? |
My suggestion is:
My assumption is that the label will contain the NSB level and perhaps additional info. |
My suggestion would to use this then in general for files of this type generated by simtools (and for ray tracing results, we replace gamma by e.g., |
Sounds good, I will try to do that wherever possible (once I finish with the current project). |
After the refactoring the filenames have a different structure than in the current official productions. Check if going back to the old style does not introduce complications in the code.
The text was updated successfully, but these errors were encountered: