Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmission issues in integration test #1106

Open
orelgueta opened this issue Aug 27, 2024 · 1 comment
Open

Transmission issues in integration test #1106

orelgueta opened this issue Aug 27, 2024 · 1 comment

Comments

@orelgueta
Copy link
Contributor

orelgueta commented Aug 27, 2024

I've looked into

pytest --no-cov "tests/integration_tests/test_applications_from_config.py::test_applications_from_config[simtools-simulate-prod_gamma_20_deg]"

and files (although very small ones are generated for me at /tmp/pytest-of-root/pytest-1/test-data0/simtools-simulate-prod-gamma_20_deg/simtools-output/test-production//simtel-data/North/gamma/data/run000002_gamma_za020deg_azm000deg_North_TestLayout_test-production.simtel.zst

The log files look reasonable and it runs through without errors.

There are issues, many statements like

Warning: problematic transmission between telescope and observation level.
Evaluation was between observation layer at 21.560000 m a.s.l.
and 31.000000 m above, plus 16.000000 m in the telescope.
Lookup in transmission table in wavelength range from 200 to 1000 nm,
   altitude range from 2.156000 to 100.000000 km a.s.l.,
   for wavelength 400 nm from 0.052560 km a.s.l., for airmass factor 1.000000
Starting altitude of 0.052560 km is out of range (2.156000 to 100.000000 km).
This is either an underground installation or the wrong transmission table.
At 400 nm we get a transm. of 0.000000 between tel. and obs.lev., and 0.000000 inside tel.
Your transmission table might not be appropriate for the given site.
We are ignoring this problematic part now but you should fix your set-up.

in the log file.

Originally posted by @GernotMaier in #875 (comment)

Was this resolved in the meantime? The original PR does not refer to this issue again and a search for these warnings does not appear anywhere else in the repo. Therefore I am opening this issue so that we remember to check it.

@GernotMaier
Copy link
Contributor

Tried to remember and reread the issues / pull requests, but seems we didn't address this (multiple points were addressed).

This is a good point and I actually suggested / wanted to suggest that we move all those test functions from test_applications_from_config.py to a separate test module. This would be cleaner and allow us as well to write unit tests on this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@GernotMaier @orelgueta and others