Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests of KeyError after positions calibration_elements are added to DB #1051

Open
tobiaskleiner opened this issue Jul 9, 2024 · 4 comments
Assignees

Comments

@tobiaskleiner
Copy link
Collaborator

In export_array_elements_as_table in array_model.

@GernotMaier
Copy link
Contributor

@tobiaskleiner - I guess you mean this function here?

def export_array_elements_as_table(self, coordinate_system="ground"):

(Always better to add a permanent link to issues.

Where exactly do you want to add a test for KeyError? Or is it already implemented and this issue is obsolete?

@tobiaskleiner
Copy link
Collaborator Author

@GernotMaier the current implementation doesn't export the coordinates of other array elements, only telescope model positions. Maybe we can generalize this.?
Then the KeyError test is not really needed anymore as there is the try ... except now.

@GernotMaier
Copy link
Contributor

Yes, this should be generalised (possibly with the option of given a list of array element types in the call).

But do I see correctly the array_model only knows about telescopes as array elements, but about the calibration devices?

@tobiaskleiner
Copy link
Collaborator Author

Yes this needs to be added if we want to output all elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants