Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirFileSystem.ls() has detail=True as default #899

Open
benlindsay opened this issue Feb 2, 2022 · 7 comments
Open

DirFileSystem.ls() has detail=True as default #899

benlindsay opened this issue Feb 2, 2022 · 7 comments

Comments

@benlindsay
Copy link

benlindsay commented Feb 2, 2022

In the DirFileSystem implementation, the detail parameter is set to True by default (see here and here) whereas for other implementations like LocalFileSystem, it is set to False (see here). This makes it so that ls() will give a list of dictionaries instead of a list of strings. Can we set that parameter to False by default so it has the expected behavior?

Pinging @efiop and @lucmos since you two coded up the DirFileSystem I think. Thanks for putting that together!

@martindurant
Copy link
Member

Yes, we would like to aim for consistency across the implementations. I suspect this particular argument may be inconsistent in more places than the one you noticed.

@benlindsay
Copy link
Author

Oh interesting, I see that the AbstractFileSystem sets detail=True by default, so I guess the cleanup should go in the other direction...maybe LocalFileSystem and others should change theirs to detail=True

@benlindsay
Copy link
Author

Not super related, but is there a plan to add another release soon? I'd love to use DirFileSystem in an internal app at work but it's hard without a release. Thanks!

@martindurant
Copy link
Member

In theory, we can release whenever we have accumulated enough new stuff or something critical comes up. It doesn't cost me too. much effort. We've been doing one or two releases a month.

@benlindsay
Copy link
Author

@martindurant Any updates on when a new release might come out? Still really looking forward to using DirFileSystem in a project. Thanks in advance!!

@martindurant
Copy link
Member

On PyPI now

@benlindsay
Copy link
Author

woohoo, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants