diff --git a/packages/devtools_app/lib/src/screens/network/network_controller.dart b/packages/devtools_app/lib/src/screens/network/network_controller.dart index 7bc352d367b..5e3d1b156f6 100644 --- a/packages/devtools_app/lib/src/screens/network/network_controller.dart +++ b/packages/devtools_app/lib/src/screens/network/network_controller.dart @@ -169,23 +169,21 @@ class NetworkController extends DisposableController void _initHelper() async { try { - if (offlineDataController.showingOfflineData.value == true) { + if (offlineDataController.showingOfflineData.value) { await maybeLoadOfflineData( NetworkScreen.id, createData: (json) => OfflineNetworkData.fromJson(json), shouldLoad: (data) => !data.isEmpty, loadData: (data) => loadOfflineData(data), ); - } - cancelListeners(); - if (!offlineDataController.showingOfflineData.value) { + }else{ unawaited(startRecording()); debugPrint('started recording'); addAutoDisposeListener( serviceConnection.serviceManager.isolateManager.mainIsolate, - () { + () { if (serviceConnection - .serviceManager.isolateManager.mainIsolate.value != + .serviceManager.isolateManager.mainIsolate.value != null) { unawaited(startRecording()); } diff --git a/packages/devtools_app/lib/src/screens/network/offline_network_data.dart b/packages/devtools_app/lib/src/screens/network/offline_network_data.dart index 2322b7dc691..3f29d64440c 100644 --- a/packages/devtools_app/lib/src/screens/network/offline_network_data.dart +++ b/packages/devtools_app/lib/src/screens/network/offline_network_data.dart @@ -9,12 +9,12 @@ import '../../shared/primitives/utils.dart'; import 'network_model.dart'; /// Class to encapsulate offline data for the [NetworkController]. +/// /// It is responsible for serializing and deserializing offline network data. class OfflineNetworkData with Serializable { OfflineNetworkData({ required this.requests, this.selectedRequestId, - this.recording = false, }); /// Creates an instance of [OfflineNetworkData] from a JSON map. @@ -33,7 +33,6 @@ class OfflineNetworkData with Serializable { return OfflineNetworkData( requests: requests, selectedRequestId: json['selectedRequestId'] as String?, - recording: json['recording'] as bool? ?? false, ); } bool get isEmpty => requests.isNullOrEmpty; @@ -54,16 +53,12 @@ class OfflineNetworkData with Serializable { /// The ID of the currently selected request, if any. final String? selectedRequestId; - /// Whether the recording state is enabled. - final bool recording; - /// Converts the current offline data to a JSON format. @override Map toJson() { return { 'requests': requests.map((request) => request.toJson()).toList(), 'selectedRequestId': selectedRequestId, - 'recording': recording, }; } }