Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Add otel and general metrics for boolean evaluation #1871

Merged
merged 3 commits into from
Jul 15, 2023

Conversation

yquansah
Copy link
Contributor

Add otel/general metrics to boolean evaluation.

Completes FLI-495

@yquansah yquansah requested a review from a team as a code owner July 14, 2023 17:42
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1871 (a1ec0b6) into eval-v2 (d307321) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           eval-v2    #1871      +/-   ##
===========================================
+ Coverage    71.45%   71.68%   +0.22%     
===========================================
  Files           63       63              
  Lines         6093     6142      +49     
===========================================
+ Hits          4354     4403      +49     
  Misses        1491     1491              
  Partials       248      248              
Impacted Files Coverage Δ
internal/server/evaluation/evaluation.go 89.26% <100.00%> (+1.11%) ⬆️
internal/server/evaluation/evaluator.go 97.44% <100.00%> (+0.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@yquansah yquansah merged commit c33fba5 into eval-v2 Jul 15, 2023
17 of 20 checks passed
@yquansah yquansah deleted the boolean-otel-metrics branch July 15, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants