Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): ability to skip authentication for top-level api prefixes #1854

Merged
merged 5 commits into from
Jul 11, 2023

Merge branch 'eval-v2' into gm/authentication-exclude

0634708
Select commit
Loading
Failed to load commit list.
Merged

feat(auth): ability to skip authentication for top-level api prefixes #1854

Merge branch 'eval-v2' into gm/authentication-exclude
0634708
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 11, 2023 in 1s

71.45% (+0.22%) compared to bbfacc5

View this Pull Request on Codecov

71.45% (+0.22%) compared to bbfacc5

Details

Codecov Report

Merging #1854 (0634708) into eval-v2 (bbfacc5) will increase coverage by 0.22%.
The diff coverage is 34.52%.

@@             Coverage Diff             @@
##           eval-v2    #1854      +/-   ##
===========================================
+ Coverage    71.23%   71.45%   +0.22%     
===========================================
  Files           63       63              
  Lines         6022     6093      +71     
===========================================
+ Hits          4290     4354      +64     
  Misses        1491     1491              
- Partials       241      248       +7     
Impacted Files Coverage Δ
internal/cmd/auth.go 0.00% <0.00%> (ø)
internal/cmd/grpc.go 0.00% <0.00%> (ø)
internal/config/authentication.go 71.42% <ø> (ø)
internal/server/middleware/grpc/middleware.go 63.10% <37.03%> (-6.10%) ⬇️
internal/server/rollout.go 87.50% <100.00%> (+87.50%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more