Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware): support caching new evaluation RPCs #1853

Merged
merged 3 commits into from
Jul 11, 2023

Merge branch 'eval-v2' into gm/eval-v2-cache

84eae43
Select commit
Loading
Failed to load commit list.
Merged

feat(middleware): support caching new evaluation RPCs #1853

Merge branch 'eval-v2' into gm/eval-v2-cache
84eae43
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 11, 2023 in 0s

71.50% (-0.42%) compared to 52d30db

View this Pull Request on Codecov

71.50% (-0.42%) compared to 52d30db

Details

Codecov Report

Merging #1853 (84eae43) into eval-v2 (52d30db) will decrease coverage by 0.42%.
The diff coverage is 37.03%.

@@             Coverage Diff             @@
##           eval-v2    #1853      +/-   ##
===========================================
- Coverage    71.91%   71.50%   -0.42%     
===========================================
  Files           63       63              
  Lines         6028     6081      +53     
===========================================
+ Hits          4335     4348      +13     
- Misses        1451     1483      +32     
- Partials       242      250       +8     
Impacted Files Coverage Δ
internal/server/middleware/grpc/middleware.go 63.10% <37.03%> (-6.10%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more