Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext): add support for flag type and rollout definitions #1826

Merged
merged 17 commits into from
Jul 7, 2023
Merged

feat(ext): add support for flag type and rollout definitions #1826

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
cb4f979
test(ext): add failing cases for new version 1.1 and rollouts
GeorgeMac Jul 5, 2023
8da8471
feat(ext): add support for flag type and rollout definitions
GeorgeMac Jul 5, 2023
853b20d
fix(ext): adding missing error not-nil check
GeorgeMac Jul 5, 2023
9c2361c
test(readonly): bump testdata import version
GeorgeMac Jul 5, 2023
581bc0f
fix(ext): support rename from rollout percentage to threshold
GeorgeMac Jul 5, 2023
cc3fe94
fix(ext): ensure minimum version enforced as expected
GeorgeMac Jul 5, 2023
082a913
test(readonly): update suite with boolean flag assertions
GeorgeMac Jul 5, 2023
f78da77
feat(ext): support implicit rank in flag state version 1.1
GeorgeMac Jul 5, 2023
4a51fb6
chore(ext): correct typos in comments
GeorgeMac Jul 5, 2023
5cd47e3
fix(test/cli): update assertion for import/export
GeorgeMac Jul 5, 2023
c280be1
feat(validate): add support for state version 1.1
GeorgeMac Jul 6, 2023
3458c21
chore(build): address comment fix suggestions
GeorgeMac Jul 6, 2023
abc8a70
fix(test/migration): use an import file valid for latest
GeorgeMac Jul 6, 2023
139f9d7
Merge branch 'eval-v2' into gm/eval-import-export
GeorgeMac Jul 6, 2023
a04b670
Merge branch 'eval-v2' into gm/eval-import-export
GeorgeMac Jul 6, 2023
0e6875e
fix(test/migration): import using latest build not tip
GeorgeMac Jul 7, 2023
098465f
Merge branch 'gm/eval-import-export' of github.com:flipt-io/flipt int…
GeorgeMac Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/testing/integration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ func importExport(ctx context.Context, _ *dagger.Client, base, flipt *dagger.Con

diff := cmp.Diff(expected, generated)
if diff != "" {
fmt.Printf("Unexpected difference in %q exported output:\n", conf.name)
fmt.Printf("Unexpected difference in %q exported output: \n", conf.name)
fmt.Println(diff)
return errors.New("exported yaml did not match")
}
Expand Down
2 changes: 1 addition & 1 deletion build/testing/integration/readonly/readonly_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func TestReadOnly(t *testing.T) {
require.NoError(t, err)

if flags.NextPageToken == "" {
// ensure last page contains 2 entres (boolean and disabled)
// ensure last page contains 2 entries (boolean and disabled)
assert.Len(t, flags.Flags, 2)

found = append(found, flags.Flags...)
Expand Down
2 changes: 1 addition & 1 deletion build/testing/migration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func Migration(ctx context.Context, client *dagger.Client, base, flipt *dagger.C

// import testdata into latest Flipt instance
_, err = flipt.
WithFile("import.yaml", base.File("build/testing/integration/readonly/testdata/default.yaml")).
WithFile("import.yaml", base.File("build/testing/testdata/migration/default.yaml")).
WithServiceBinding("flipt", latest.WithExec(nil)).
WithExec([]string{"/flipt", "import", "--address", "grpc://flipt:9000", "import.yaml"}).
Sync(ctx)
Expand Down
Loading
Loading