-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext): add support for flag type and rollout definitions #1826
Merged
Merged
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cb4f979
test(ext): add failing cases for new version 1.1 and rollouts
GeorgeMac 8da8471
feat(ext): add support for flag type and rollout definitions
GeorgeMac 853b20d
fix(ext): adding missing error not-nil check
GeorgeMac 9c2361c
test(readonly): bump testdata import version
GeorgeMac 581bc0f
fix(ext): support rename from rollout percentage to threshold
GeorgeMac cc3fe94
fix(ext): ensure minimum version enforced as expected
GeorgeMac 082a913
test(readonly): update suite with boolean flag assertions
GeorgeMac f78da77
feat(ext): support implicit rank in flag state version 1.1
GeorgeMac 4a51fb6
chore(ext): correct typos in comments
GeorgeMac 5cd47e3
fix(test/cli): update assertion for import/export
GeorgeMac c280be1
feat(validate): add support for state version 1.1
GeorgeMac 3458c21
chore(build): address comment fix suggestions
GeorgeMac abc8a70
fix(test/migration): use an import file valid for latest
GeorgeMac 139f9d7
Merge branch 'eval-v2' into gm/eval-import-export
GeorgeMac a04b670
Merge branch 'eval-v2' into gm/eval-import-export
GeorgeMac 0e6875e
fix(test/migration): import using latest build not tip
GeorgeMac 098465f
Merge branch 'gm/eval-import-export' of github.com:flipt-io/flipt int…
GeorgeMac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -101,7 +101,7 @@ func TestReadOnly(t *testing.T) { | |||||
NamespaceKey: namespace, | ||||||
}) | ||||||
require.NoError(t, err) | ||||||
require.Len(t, flags.Flags, 51) | ||||||
require.Len(t, flags.Flags, 52) | ||||||
|
||||||
flag := flags.Flags[0] | ||||||
assert.Equal(t, namespace, flag.NamespaceKey) | ||||||
|
@@ -128,8 +128,8 @@ func TestReadOnly(t *testing.T) { | |||||
require.NoError(t, err) | ||||||
|
||||||
if flags.NextPageToken == "" { | ||||||
// ensure last page contains 1 entry | ||||||
assert.Len(t, flags.Flags, 1) | ||||||
// ensure last page contains 2 entres (boolean and disabled) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
assert.Len(t, flags.Flags, 2) | ||||||
|
||||||
found = append(found, flags.Flags...) | ||||||
|
||||||
|
@@ -144,7 +144,7 @@ func TestReadOnly(t *testing.T) { | |||||
nextPage = flags.NextPageToken | ||||||
} | ||||||
|
||||||
require.Len(t, found, 51) | ||||||
require.Len(t, found, 52) | ||||||
}) | ||||||
}) | ||||||
|
||||||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.