Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(integration): ensure Evaluation.Variant returns as expected #1800

Merged
merged 6 commits into from
Jun 30, 2023
Merged

test(integration): ensure Evaluation.Variant returns as expected #1800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94527e1
test(integration/api): ensure Evaluation.Variant returns as expected
GeorgeMac Jun 28, 2023
d89a40a
test(integration/readonly): ensure Evaluation.Variant returns as expe…
GeorgeMac Jun 28, 2023
a67e0d5
fix(build/testing): set production yaml version to 1.0
GeorgeMac Jun 28, 2023
3f9200c
fix(build/testing/api): ensure disabled flag is created and listed
GeorgeMac Jun 29, 2023
5378625
fix(build/testing/api): fix disabled flag asserts and delete before n…
GeorgeMac Jun 29, 2023
d0b5106
fix(build/testdata): typo on name field case
GeorgeMac Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
212 changes: 154 additions & 58 deletions build/testing/integration/api/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.flipt.io/flipt/rpc/flipt"
"go.flipt.io/flipt/rpc/flipt/evaluation"
sdk "go.flipt.io/flipt/sdk/go"
)

Expand Down Expand Up @@ -107,6 +108,22 @@ func API(t *testing.T, ctx context.Context, client sdk.SDK, namespace string, au
assert.Equal(t, "This is a test flag", created.Description)
assert.True(t, created.Enabled, "Flag should be enabled")

t.Log("Create a new flag in a disabled state.")

disabled, err := client.Flipt().CreateFlag(ctx, &flipt.CreateFlagRequest{
NamespaceKey: namespace,
Key: "disabled",
Name: "Disabled",
Description: "This is a disabled test flag",
Enabled: false,
})
require.NoError(t, err)

assert.Equal(t, "disabled", disabled.Key)
assert.Equal(t, "Disabled", disabled.Name)
assert.Equal(t, "This is a disabled test flag", disabled.Description)
assert.False(t, disabled.Enabled, "Flag should be disabled")

t.Log("Retrieve flag with key \"test\".")

flag, err := client.Flipt().GetFlag(ctx, &flipt.GetFlagRequest{
Expand Down Expand Up @@ -146,11 +163,15 @@ func API(t *testing.T, ctx context.Context, client sdk.SDK, namespace string, au
})
require.NoError(t, err)

assert.Len(t, flags.Flags, 1)
assert.Len(t, flags.Flags, 2)
assert.Equal(t, updated.Key, flags.Flags[0].Key)
assert.Equal(t, updated.Name, flags.Flags[0].Name)
assert.Equal(t, updated.Description, flags.Flags[0].Description)

assert.Equal(t, disabled.Key, flags.Flags[1].Key)
assert.Equal(t, disabled.Name, flags.Flags[1].Name)
assert.Equal(t, disabled.Description, flags.Flags[1].Description)

for _, key := range []string{"one", "two"} {
t.Logf("Create variant with key %q.", key)

Expand Down Expand Up @@ -473,88 +494,157 @@ func API(t *testing.T, ctx context.Context, client sdk.SDK, namespace string, au
assert.Equal(t, float32(100), distribution.Rollout)
})

t.Run("Evaluation", func(t *testing.T) {
t.Log(`Successful match.`)
t.Run("Legacy", func(t *testing.T) {
t.Run("Evaluation", func(t *testing.T) {
t.Log(`Successful match.`)

result, err := client.Flipt().Evaluate(ctx, &flipt.EvaluationRequest{
NamespaceKey: namespace,
FlagKey: "test",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{
"foo": "baz",
"fizz": "bozz",
},
})
require.NoError(t, err)
result, err := client.Flipt().Evaluate(ctx, &flipt.EvaluationRequest{
NamespaceKey: namespace,
FlagKey: "test",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{
"foo": "baz",
"fizz": "bozz",
},
})
require.NoError(t, err)

require.True(t, result.Match, "Evaluation should have matched.")
assert.Equal(t, "everyone", result.SegmentKey)
assert.Equal(t, "one", result.Value)
assert.Equal(t, flipt.EvaluationReason_MATCH_EVALUATION_REASON, result.Reason)
require.True(t, result.Match, "Evaluation should have matched.")
assert.Equal(t, "everyone", result.SegmentKey)
assert.Equal(t, "one", result.Value)
assert.Equal(t, flipt.EvaluationReason_MATCH_EVALUATION_REASON, result.Reason)

t.Log(`Unsuccessful match.`)
t.Log(`Unsuccessful match.`)

result, err = client.Flipt().Evaluate(ctx, &flipt.EvaluationRequest{
NamespaceKey: namespace,
FlagKey: "test",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{
"fizz": "buzz",
},
result, err = client.Flipt().Evaluate(ctx, &flipt.EvaluationRequest{
NamespaceKey: namespace,
FlagKey: "test",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{
"fizz": "buzz",
},
})
require.NoError(t, err)

assert.False(t, result.Match, "Evaluation should not have matched.")
})
require.NoError(t, err)

assert.False(t, result.Match, "Evaluation should not have matched.")
})
t.Run("Batch Evaluation", func(t *testing.T) {
t.Log(`Successful match.`)

t.Run("Batch Evaluation", func(t *testing.T) {
t.Log(`Successful match.`)
results, err := client.Flipt().BatchEvaluate(ctx, &flipt.BatchEvaluationRequest{
NamespaceKey: namespace,
Requests: []*flipt.EvaluationRequest{
{
NamespaceKey: namespace,
FlagKey: "test",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{
"foo": "baz",
"fizz": "bozz",
},
},
},
})
require.NoError(t, err)

results, err := client.Flipt().BatchEvaluate(ctx, &flipt.BatchEvaluationRequest{
NamespaceKey: namespace,
Requests: []*flipt.EvaluationRequest{
{
require.Len(t, results.Responses, 1)
result := results.Responses[0]

require.True(t, result.Match, "Evaluation should have matched.")
assert.Equal(t, "everyone", result.SegmentKey)
assert.Equal(t, "one", result.Value)
assert.Equal(t, flipt.EvaluationReason_MATCH_EVALUATION_REASON, result.Reason)

t.Log(`Unsuccessful match.`)

results, err = client.Flipt().BatchEvaluate(ctx, &flipt.BatchEvaluationRequest{
NamespaceKey: namespace,
Requests: []*flipt.EvaluationRequest{
{
NamespaceKey: namespace,
FlagKey: "test",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{
"fizz": "buzz",
},
},
},
})
require.NoError(t, err)

require.Len(t, results.Responses, 1)
result = results.Responses[0]

assert.False(t, result.Match, "Evaluation should not have matched.")
})
})

t.Run("Evaluation", func(t *testing.T) {
t.Run("Variant", func(t *testing.T) {
t.Run("successful match", func(t *testing.T) {
result, err := client.Evaluation().Variant(ctx, &evaluation.EvaluationRequest{
NamespaceKey: namespace,
FlagKey: "test",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{
"foo": "baz",
"fizz": "bozz",
},
},
},
})
require.NoError(t, err)
})
require.NoError(t, err)

require.Len(t, results.Responses, 1)
result := results.Responses[0]

require.True(t, result.Match, "Evaluation should have matched.")
assert.Equal(t, "everyone", result.SegmentKey)
assert.Equal(t, "one", result.Value)
assert.Equal(t, flipt.EvaluationReason_MATCH_EVALUATION_REASON, result.Reason)

t.Log(`Unsuccessful match.`)
require.True(t, result.Match, "Evaluation should have matched.")
assert.Equal(t, "everyone", result.SegmentKey)
assert.Equal(t, "one", result.VariantKey)
assert.Equal(t, evaluation.EvaluationReason_MATCH_EVALUATION_REASON, result.Reason)
})

results, err = client.Flipt().BatchEvaluate(ctx, &flipt.BatchEvaluationRequest{
NamespaceKey: namespace,
Requests: []*flipt.EvaluationRequest{
{
t.Run("no match", func(t *testing.T) {
result, err := client.Evaluation().Variant(ctx, &evaluation.EvaluationRequest{
NamespaceKey: namespace,
FlagKey: "test",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{
"fizz": "buzz",
},
},
},
})
require.NoError(t, err)
})
require.NoError(t, err)

assert.False(t, result.Match, "Evaluation should not have matched.")
assert.Equal(t, evaluation.EvaluationReason_UNKNOWN_EVALUATION_REASON, result.Reason)
assert.Empty(t, result.SegmentKey)
assert.Empty(t, result.VariantKey)
})

t.Run("flag disabled", func(t *testing.T) {
result, err := client.Evaluation().Variant(ctx, &evaluation.EvaluationRequest{
NamespaceKey: namespace,
FlagKey: "disabled",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{},
})
require.NoError(t, err)

assert.False(t, result.Match, "Evaluation should not have matched.")
assert.Equal(t, evaluation.EvaluationReason_FLAG_DISABLED_EVALUATION_REASON, result.Reason)
assert.Empty(t, result.SegmentKey)
assert.Empty(t, result.VariantKey)
})

require.Len(t, results.Responses, 1)
result = results.Responses[0]
t.Run("flag not found", func(t *testing.T) {
result, err := client.Evaluation().Variant(ctx, &evaluation.EvaluationRequest{
NamespaceKey: namespace,
FlagKey: "unknown_flag",
EntityId: uuid.Must(uuid.NewV4()).String(),
Context: map[string]string{},
})

assert.False(t, result.Match, "Evaluation should not have matched.")
msg := fmt.Sprintf("rpc error: code = NotFound desc = flag \"%s/unknown_flag\" not found", namespace)
require.EqualError(t, err, msg)
require.Nil(t, result)
})
})
})

t.Run("Delete", func(t *testing.T) {
Expand Down Expand Up @@ -590,6 +680,12 @@ func API(t *testing.T, ctx context.Context, client sdk.SDK, namespace string, au
})
require.NoError(t, err)

err = client.Flipt().DeleteFlag(ctx, &flipt.DeleteFlagRequest{
NamespaceKey: namespace,
Key: "disabled",
})
require.NoError(t, err)

t.Log(`Segment.`)
err = client.Flipt().DeleteSegment(ctx, &flipt.DeleteSegmentRequest{
NamespaceKey: namespace,
Expand Down
Loading
Loading