feat(rpc): define auth protobuf package and Authentication model #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we create a short lived feature branch to base this off of instead of I realize the irony of this |
|
@markphelps yeah, works for me. I'll base this off something like I'll keep opening them as PRs on that branch? To aid in breaking up the review process. |
|
I cut a branch |
markphelps
reviewed
Oct 25, 2022
GeorgeMac
force-pushed
the
gm/authentication-protobuf
branch
from
8fe812d
to
ade17a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports #779
This is a foundational PR which establishes a core Authentication model in protobuf.
Along with establishing a new
rpc/flipt/authprotobuf definitions sub-package.There's no functional value to this PR yet. It will be integrated in a subsequent PR.